Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2399673005: Normalize non-breaking spaces into spaces (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Normalize non-breaking spaces into spaces Since we take direct diffs of text field values to make text unit transitions (e.g. character, word, line moves/selections), we need to ensure any non-breaking whitespaces get normalized as content editables use space/nbsp interchangably. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/209f8a15175dcd9cb5451d50500c357449dd8f10 Cr-Commit-Position: refs/heads/master@{#426211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
David Tseng
Mind taking a quick look at this one also? Thanks.
4 years, 2 months ago (2016-10-06 21:47:36 UTC) #3
David Tseng
4 years, 2 months ago (2016-10-14 13:08:09 UTC) #6
dmazzoni
lgtm
4 years, 2 months ago (2016-10-17 05:05:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399673005/1
4 years, 2 months ago (2016-10-19 15:04:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 16:04:00 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:09:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/209f8a15175dcd9cb5451d50500c357449dd8f10
Cr-Commit-Position: refs/heads/master@{#426211}

Powered by Google App Engine
This is Rietveld 408576698