Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2402913002: MD History: Fix minor visual inconsistencies (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix minor visual inconsistencies * Remove tap highlight on synced device card titles * Adjust padding on history list so that 'no results' messages align correctly BUG=653817, 653782 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/6e5c2bc09cede88979793107a21d9202559eae40 Cr-Commit-Position: refs/heads/master@{#426181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_list.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
tsergeant
4 years, 2 months ago (2016-10-10 03:48:59 UTC) #7
calamity
lgtm
4 years, 2 months ago (2016-10-14 10:59:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402913002/1
4 years, 2 months ago (2016-10-19 10:08:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/298884)
4 years, 2 months ago (2016-10-19 13:08:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402913002/1
4 years, 2 months ago (2016-10-19 13:35:12 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 14:26:58 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:08:02 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e5c2bc09cede88979793107a21d9202559eae40
Cr-Commit-Position: refs/heads/master@{#426181}

Powered by Google App Engine
This is Rietveld 408576698