Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2422963002: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/extensions (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FOR_EACH_OBSERVER macro usage in chrome/browser/extensions Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0 Cr-Commit-Position: refs/heads/master@{#426132}

Patch Set 1 #

Patch Set 2 : extensions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -123 lines) Patch
M chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/cast_devices_private/cast_devices_private_api.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 1 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_store.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_service.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/mdns/dns_sd_registry.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/blacklist.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/error_console/error_console.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_error_reporter.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_management.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/install_tracker.cc View 1 4 chunks +20 lines, -17 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/window_controller_list.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 16 chunks +32 lines, -48 lines 0 comments Download

Messages

Total messages: 31 (17 generated)
Eric Willigers
4 years, 2 months ago (2016-10-17 01:27:13 UTC) #5
Lei Zhang
Please ask chrome/browser/extensions/OWNERS instead. chrome/browser/profiles/profile_info_cache.cc LGTM
4 years, 2 months ago (2016-10-17 06:31:22 UTC) #8
Eric Willigers
4 years, 2 months ago (2016-10-17 07:32:00 UTC) #10
Eric Willigers
4 years, 2 months ago (2016-10-17 07:32:01 UTC) #11
Eric Willigers
4 years, 2 months ago (2016-10-17 22:24:17 UTC) #13
asargent_no_longer_on_chrome
lgtm
4 years, 2 months ago (2016-10-18 16:02:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422963002/20001
4 years, 2 months ago (2016-10-18 22:44:27 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/245763)
4 years, 2 months ago (2016-10-19 00:13:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422963002/20001
4 years, 2 months ago (2016-10-19 00:15:14 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/284153) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 2 months ago (2016-10-19 01:35:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422963002/20001
4 years, 2 months ago (2016-10-19 02:03:02 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422963002/20001
4 years, 2 months ago (2016-10-19 03:20:08 UTC) #27
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 04:15:31 UTC) #29
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:06:22 UTC) #31
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0
Cr-Commit-Position: refs/heads/master@{#426132}

Powered by Google App Engine
This is Rietveld 408576698