Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: chrome/browser/extensions/error_console/error_console.cc

Issue 2422963002: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/extensions (Closed)
Patch Set: extensions Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/blacklist.cc ('k') | chrome/browser/extensions/extension_error_reporter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/error_console/error_console.cc
diff --git a/chrome/browser/extensions/error_console/error_console.cc b/chrome/browser/extensions/error_console/error_console.cc
index 07574f363b7554beffdcb1b119f6fc4b01eb72d4..e59b653c9ff45f15014479e51ddfd7147f3dfd60 100644
--- a/chrome/browser/extensions/error_console/error_console.cc
+++ b/chrome/browser/extensions/error_console/error_console.cc
@@ -75,7 +75,8 @@ ErrorConsole::ErrorConsole(Profile* profile)
}
ErrorConsole::~ErrorConsole() {
- FOR_EACH_OBSERVER(Observer, observers_, OnErrorConsoleDestroyed());
+ for (auto& observer : observers_)
+ observer.OnErrorConsoleDestroyed();
}
// static
@@ -146,13 +147,15 @@ void ErrorConsole::ReportError(std::unique_ptr<ExtensionError> error) {
return;
const ExtensionError* weak_error = errors_.AddError(std::move(error));
- FOR_EACH_OBSERVER(Observer, observers_, OnErrorAdded(weak_error));
+ for (auto& observer : observers_)
+ observer.OnErrorAdded(weak_error);
}
void ErrorConsole::RemoveErrors(const ErrorMap::Filter& filter) {
std::set<std::string> affected_ids;
errors_.RemoveErrors(filter, &affected_ids);
- FOR_EACH_OBSERVER(Observer, observers_, OnErrorsRemoved(affected_ids));
+ for (auto& observer : observers_)
+ observer.OnErrorsRemoved(affected_ids);
}
const ErrorList& ErrorConsole::GetErrorsForExtension(
« no previous file with comments | « chrome/browser/extensions/blacklist.cc ('k') | chrome/browser/extensions/extension_error_reporter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698