Remove FOR_EACH_OBSERVER macro usage in chrome/browser/extensions

chrome/browser/extensions/api/commands/command_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/commands/command_service.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/lazy_instance.h"
@@ skipping 276 matching lines @@
   std::unique_ptr<base::DictionaryValue> command_keys(
       new base::DictionaryValue);
   command_keys->SetBoolean(kSuggestedKeyWasAssigned, true);
   std::unique_ptr<base::DictionaryValue> suggested_key_prefs(
       new base::DictionaryValue);
   suggested_key_prefs->Set(command_name, command_keys.release());
   MergeSuggestedKeyPrefs(extension_id, ExtensionPrefs::Get(profile_),
                          std::move(suggested_key_prefs));
 
   // Fetch the newly-updated command, and notify the observers.
-  FOR_EACH_OBSERVER(
-      Observer,
-      observers_,
-      OnExtensionCommandAdded(extension_id,
-                              FindCommandByName(extension_id, command_name)));
+  for (auto& observer : observers_) {
+    observer.OnExtensionCommandAdded(
+        extension_id, FindCommandByName(extension_id, command_name));
+  }
 
   // TODO(devlin): Deprecate this notification in favor of the observers.
   std::pair<const std::string, const std::string> details =
       std::make_pair(extension_id, command_name);
   content::NotificationService::current()->Notify(
       extensions::NOTIFICATION_EXTENSION_COMMAND_ADDED,
       content::Source<Profile>(profile_),
       content::Details<std::pair<const std::string, const std::string> >(
           &details));
 
@@ skipping 530 matching lines @@
     // TODO(devlin): Deprecate this notification in favor of the observers.
     ExtensionCommandRemovedDetails details(extension_id, command_name,
                                            StripCurrentPlatform(key));
     content::NotificationService::current()->Notify(
         extensions::NOTIFICATION_EXTENSION_COMMAND_REMOVED,
         content::Source<Profile>(profile_),
         content::Details<ExtensionCommandRemovedDetails>(&details));
   }
 
   for (const Command& removed_command : removed_commands) {
-    FOR_EACH_OBSERVER(
-        Observer,
-        observers_,
-        OnExtensionCommandRemoved(extension_id, removed_command));
+    for (auto& observer : observers_)
+      observer.OnExtensionCommandRemoved(extension_id, removed_command);
   }
 }
 
 bool CommandService::GetExtensionActionCommand(
     const std::string& extension_id,
     QueryType query_type,
     Command* command,
     bool* active,
     ExtensionCommandType action_type) const {
   const ExtensionSet& extensions =
@@ skipping 45 matching lines @@
   return true;
 }
 
 template <>
 void
 BrowserContextKeyedAPIFactory<CommandService>::DeclareFactoryDependencies() {
   DependsOn(ExtensionCommandsGlobalRegistry::GetFactoryInstance());
 }
 
 }  // namespace extensions