Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2422303003: Remove FWL Create methods, use new instead (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, npm, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FWL Create methods, use new instead Committed: https://pdfium.googlesource.com/pdfium/+/0ca71ec811e33818d2ccba3221fdb660811b813c

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -64 lines) Patch
M xfa/fwl/lightwidget/cfwl_barcode.h View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_barcode.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_checkbox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_checkbox.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_combobox.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_combobox.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_datetimepicker.h View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_datetimepicker.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_edit.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_edit.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_listbox.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_listbox.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_picturebox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_picturebox.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_pushbutton.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_pushbutton.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpushbutton.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 2418413005 Patch 20001

Dependent Patchsets:

Issue 2433103002 Patch 1

Messages

Total messages: 17 (12 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-18 15:35:43 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/2422303003/diff/1/xfa/fxfa/app/xfa_ffbarcode.cpp File xfa/fxfa/app/xfa_ffbarcode.cpp (right): https://codereview.chromium.org/2422303003/diff/1/xfa/fxfa/app/xfa_ffbarcode.cpp#newcode125 xfa/fxfa/app/xfa_ffbarcode.cpp:125: if (pFWLBarcode) { remove https://codereview.chromium.org/2422303003/diff/1/xfa/fxfa/app/xfa_ffpushbutton.cpp File xfa/fxfa/app/xfa_ffpushbutton.cpp (right): ...
4 years, 2 months ago (2016-10-18 19:12:14 UTC) #7
dsinclair
https://codereview.chromium.org/2422303003/diff/1/xfa/fxfa/app/xfa_ffbarcode.cpp File xfa/fxfa/app/xfa_ffbarcode.cpp (right): https://codereview.chromium.org/2422303003/diff/1/xfa/fxfa/app/xfa_ffbarcode.cpp#newcode125 xfa/fxfa/app/xfa_ffbarcode.cpp:125: if (pFWLBarcode) { On 2016/10/18 19:12:14, Lei Zhang wrote: ...
4 years, 2 months ago (2016-10-19 14:41:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422303003/20001
4 years, 2 months ago (2016-10-19 14:59:09 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 14:59:28 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/0ca71ec811e33818d2ccba3221fdb660811b...

Powered by Google App Engine
This is Rietveld 408576698