Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2433103002: Remove SetDataProvider from IFWL_Widget (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove SetDataProvider from IFWL_Widget Method is not called, removed. Committed: https://pdfium.googlesource.com/pdfium/+/e58febc04514694935fcdf00f604419a1e5076b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M xfa/fwl/core/fwl_formimp.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/fwl_widgetimp.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/core/fwl_widgetimp.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-19 14:44:24 UTC) #4
Wei Li
lgtm
4 years, 2 months ago (2016-10-19 16:52:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433103002/1
4 years, 2 months ago (2016-10-19 17:06:31 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 17:06:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/e58febc04514694935fcdf00f604419a1e50...

Powered by Google App Engine
This is Rietveld 408576698