Remove FWL theme subclasses

Remove FWL theme subclasses

The CFWL_CheckBoxTP and CFWL_EditTP are subclassed with the CXFA_FWLEditTP
and CXFA_FWLCheckBoxTP. The super classes are never instantiated or used, so
fold the subclasses back to the parent and use them directly.

Committed: https://pdfium.googlesource.com/pdfium/+/c273e8f5006aa7d91d37a5da021dbbabb8721e5b

[dsinclair, 2016-10-18 15:15:55]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 15:16:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-10-18 15:16:11]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-10-18 15:16:12]

PTAL.

[commit-bot: I haz the power, 2016-10-18 15:25:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 15:25:15]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-18 19:06:58]

lgtm

https://codereview.chromium.org/2418413005/diff/1/xfa/fwl/theme/cfwl_checkbox...
File xfa/fwl/theme/cfwl_checkboxtp.cpp (right):

https://codereview.chromium.org/2418413005/diff/1/xfa/fwl/theme/cfwl_checkbox...
xfa/fwl/theme/cfwl_checkboxtp.cpp:327: return TRUE;
Looking at the old CFWL_CheckBoxTP::DrawBackground(), I feel like this might
want to return FALSE? But then again, does anyone actually check the return
value from DrawBackground() ??

https://codereview.chromium.org/2418413005/diff/1/xfa/fwl/theme/cfwl_checkbox...
xfa/fwl/theme/cfwl_checkboxtp.cpp:339: const CFX_RectF* pRtBox,
(Cleaning up existing code) I think the caller should just pass a const ref
here.

https://codereview.chromium.org/2418413005/diff/1/xfa/fwl/theme/cfwl_checkbox...
xfa/fwl/theme/cfwl_checkboxtp.cpp:345: dwColor = 0xFFA9A9A9;
Merge this with the prev 2 lines?

https://codereview.chromium.org/2418413005/diff/1/xfa/fwl/theme/cfwl_checkbox...
xfa/fwl/theme/cfwl_checkboxtp.cpp:347: {
Not needed?

[dsinclair, 2016-10-19 14:38:54]

https://codereview.chromium.org/2418413005/diff/1/xfa/fwl/theme/cfwl_checkbox...
File xfa/fwl/theme/cfwl_checkboxtp.cpp (right):

https://codereview.chromium.org/2418413005/diff/1/xfa/fwl/theme/cfwl_checkbox...
xfa/fwl/theme/cfwl_checkboxtp.cpp:327: return TRUE;
On 2016/10/18 19:06:58, Lei Zhang wrote:
> Looking at the old CFWL_CheckBoxTP::DrawBackground(), I feel like this might
> want to return FALSE? But then again, does anyone actually check the return
> value from DrawBackground() ??


Made them false, I don't see any uses, will remove in a future CL.

https://codereview.chromium.org/2418413005/diff/1/xfa/fwl/theme/cfwl_checkbox...
xfa/fwl/theme/cfwl_checkboxtp.cpp:339: const CFX_RectF* pRtBox,
On 2016/10/18 19:06:58, Lei Zhang wrote:
> (Cleaning up existing code) I think the caller should just pass a const ref
> here.

Done.

https://codereview.chromium.org/2418413005/diff/1/xfa/fwl/theme/cfwl_checkbox...
xfa/fwl/theme/cfwl_checkboxtp.cpp:345: dwColor = 0xFFA9A9A9;
On 2016/10/18 19:06:58, Lei Zhang wrote:
> Merge this with the prev 2 lines?

Done.

https://codereview.chromium.org/2418413005/diff/1/xfa/fwl/theme/cfwl_checkbox...
xfa/fwl/theme/cfwl_checkboxtp.cpp:347: {
On 2016/10/18 19:06:58, Lei Zhang wrote:
> Not needed?

Done.

[dsinclair, 2016-10-19 14:38:58]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-10-19 14:38:59]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2418413005/#ps20001
(title: "Review fixes")

[commit-bot: I haz the power, 2016-10-19 14:39:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 14:48:09]

Description was changed from

==========
Remove FWL theme subclasses

The CFWL_CheckBoxTP and CFWL_EditTP are subclassed with the CXFA_FWLEditTP
and CXFA_FWLCheckBoxTP. The super classes are never instantiated or used, so
fold the subclasses back to the parent and use them directly.
==========

to

==========
Remove FWL theme subclasses

The CFWL_CheckBoxTP and CFWL_EditTP are subclassed with the CXFA_FWLEditTP
and CXFA_FWLCheckBoxTP. The super classes are never instantiated or used, so
fold the subclasses back to the parent and use them directly.

Committed:
https://pdfium.googlesource.com/pdfium/+/c273e8f5006aa7d91d37a5da021dbbabb872...
==========

[commit-bot: I haz the power, 2016-10-19 14:48:10]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/c273e8f5006aa7d91d37a5da021dbbabb872...