DevTools: allow reattaching main target live.

DevTools: allow reattaching main target live.

BUG=656055
Committed: https://crrev.com/fd4bf37272eb73d9941b547f32f5a70e117bba16
Cr-Commit-Position: refs/heads/master@{#426022}

[pfeldman, 2016-10-14 23:29:19]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-10-15 00:26:27]

https://codereview.chromium.org/2421913003/diff/60001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/2421913003/diff/60001/chrome/browser/devtools...
chrome/browser/devtools/devtools_window.cc:951:
main_web_contents_->GetController().LoadURLWithParams(load_url_params);
Remove.

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:23:
this._send("start");
Let's chain this.

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:48:
this._backend = backend;
Let's clear this._backend at some point.

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/devtools.js (right):

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/devtools.js:698:
DevToolsAPI.sendMessageToEmbedder("reattach", [], /** @type {function(?Object)}
*/ (callback));
no cast

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js
(right):

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js:302:

extra blank line

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js
(right):

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js:143:
forceClose: function()
@override

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js:145:
this._agent.detach(this._targetId, ()=>{});
() => {}

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/Connections.js (right):

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Connections.js:245:
this._yieldCallback();
Mark this as closed (disallow send and dispatch).

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js
(right):

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js:423: 
extra blank line

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:249:
interceptMainConnection: function(dispatch)
Let's rework TargetDisposed event.

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:255: var yeld
= InspectorFrontendHost.reattach.bind(InspectorFrontendHost,
this._mainTargetFactory);
yield

https://codereview.chromium.org/2421913003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:317: if
(!this._targets.includes(target))
Let's try to only remove main.

[pfeldman, 2016-10-15 01:15:02]

ALL DONE.

[dgozman, 2016-10-17 17:21:16]

lgtm

https://codereview.chromium.org/2421913003/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
(right):

https://codereview.chromium.org/2421913003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js:39:
* @param {!Object=} params
@return

https://codereview.chromium.org/2421913003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js:48:
* @override
@return

https://codereview.chromium.org/2421913003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2421913003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:314:
console.timeStamp("Main._createMainTarget begin");
time/timeEnd

https://codereview.chromium.org/2421913003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2421913003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:251: var
target = WebInspector.targetManager.mainTarget();
For hosted mode:
if (target)
  target.connection().close();

https://codereview.chromium.org/2421913003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js (right):

https://codereview.chromium.org/2421913003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js:216:
WebInspector.WorkerConnection.prototype = {
forceClose in this class is missing.

[pfeldman, 2016-10-17 18:08:53]

all done-ish

[pfeldman, 2016-10-17 19:00:43]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-10-17 19:00:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2421913003/#ps100001
(title: "review comments addressed")

[commit-bot: I haz the power, 2016-10-17 19:01:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 20:10:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 20:10:16]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pfeldman, 2016-10-17 22:53:26]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-10-17 22:53:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2421913003/#ps120001
(title: "link fixed")

[commit-bot: I haz the power, 2016-10-17 22:54:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 23:06:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 23:07:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-10-17 23:22:36]

pfeldman@chromium.org changed reviewers:
+ tsepez@chromium.org

[pfeldman, 2016-10-17 23:22:36]

+ tsepez for chrome/browser/devtools/devtools_embedder_message_dispatcher.h

no new capabilities introduced, we just allow re-establishing the connection to
the remote target.

[Tom Sepez, 2016-10-18 00:00:19]

Do any issues arise if some other devtools instance tries to re-connect to an
origin to which it doesn't belong, esp. in an oopif world?  Or is this even
possible?  LGTM otherwise.

[pfeldman, 2016-10-18 18:36:07]

In this case it does not control what it reattaches to, it'll only reattach to
the existing connection.
On a separate note, front-end is able to discover OOPIfs that belong to the
inspected page and attach to them. Leveraging this requires breaking into
devtools front-end which exposes browser cookies anyways.

[pfeldman, 2016-10-18 18:36:12]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-10-18 18:47:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 19:28:14]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-21 13:02:16]

Description was changed from

==========
DevTools: allow reattaching main target live.

BUG=656055
==========

to

==========
DevTools: allow reattaching main target live.

BUG=656055

Committed: https://crrev.com/fd4bf37272eb73d9941b547f32f5a70e117bba16
Cr-Commit-Position: refs/heads/master@{#426022}
==========

[commit-bot: I haz the power, 2016-10-21 13:02:17]

Patchset 7 (id:??) landed as
https://crrev.com/fd4bf37272eb73d9941b547f32f5a70e117bba16
Cr-Commit-Position: refs/heads/master@{#426022}