Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.h

Issue 2421913003: DevTools: allow reattaching main target live. (Closed)
Patch Set: link fixed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_ui_bindings.h
diff --git a/chrome/browser/devtools/devtools_ui_bindings.h b/chrome/browser/devtools/devtools_ui_bindings.h
index 888823492e3e871ac3b78bc8406af9f313132aec..22939c4de8cd84c3090b953ad522cbd30c098eee 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.h
+++ b/chrome/browser/devtools/devtools_ui_bindings.h
@@ -76,7 +76,7 @@ class DevToolsUIBindings : public DevToolsEmbedderMessageDispatcher::Delegate,
const base::Value* arg2,
const base::Value* arg3);
void AttachTo(const scoped_refptr<content::DevToolsAgentHost>& agent_host);
- void Reattach();
+ void Reload();
void Detach();
bool IsAttachedTo(content::DevToolsAgentHost* agent_host);
@@ -145,6 +145,7 @@ class DevToolsUIBindings : public DevToolsEmbedderMessageDispatcher::Delegate,
const std::string& value) override;
void RemovePreference(const std::string& name) override;
void ClearPreferences() override;
+ void Reattach(const DispatchCallback& callback) override;
void ReadyForTest() override;
// net::URLFetcherDelegate overrides.
@@ -221,7 +222,7 @@ class DevToolsUIBindings : public DevToolsEmbedderMessageDispatcher::Delegate,
bool devices_updates_enabled_;
bool frontend_loaded_;
- bool reattaching_;
+ bool reloading_;
std::unique_ptr<DevToolsTargetsUIHandler> remote_targets_handler_;
std::unique_ptr<PortForwardingStatusSerializer> port_status_serializer_;
PrefChangeRegistrar pref_change_registrar_;
« no previous file with comments | « chrome/browser/devtools/devtools_embedder_message_dispatcher.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698