Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js

Issue 2421913003: DevTools: allow reattaching main target live. (Closed)
Patch Set: link fixed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
index 1dd507d8b72e6114b5b41d1b1cf9d98789e784af..1969ff6a6a113ef228e14284c834b3f6a973c87d 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
@@ -78,7 +78,7 @@ WebInspector.WorkerManager.prototype = {
_reset: function()
{
for (var connection of this._connections.values())
- connection._close();
+ connection.close();
this._connections.clear();
this._targetsByWorkerId.clear();
},
@@ -119,7 +119,7 @@ WebInspector.WorkerManager.prototype = {
{
var connection = this._connections.get(workerId);
if (connection)
- connection._close();
+ connection._reportClosed();
this._connections.delete(workerId);
this._targetsByWorkerId.delete(workerId);
},
@@ -223,7 +223,7 @@ WebInspector.WorkerConnection.prototype = {
this._agent.sendMessageToWorker(this._workerId, JSON.stringify(messageObject));
},
- _close: function()
+ _reportClosed: function()
{
this.connectionClosed("worker_terminated");
},

Powered by Google App Engine
This is Rietveld 408576698