third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h - Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h

Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal… (Closed)

Patch Set: address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h b/third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h

index 9e4ada820961813086208de95bfa961a9388ea78..48b4948ab276e054fa3a9ff5c16668985976ed0f 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h

@@ -36,8 +36,6 @@ class CORE_EXPORT NGFragmentBase : public GarbageCollected<NGFragmentBase> {

LayoutUnit InlineOffset() const;

LayoutUnit BlockOffset() const;

- NGMarginStrut MarginStrut() const;

NGPhysicalFragmentBase* PhysicalFragment() const {

return physical_fragment_;

};