Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc

Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal… (Closed)
Patch Set: address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc b/third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc
index 14ea494007e6e1b52690d9505cef603ef5440143..0193580f4274530889d7a892239262b452502d32 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc
@@ -41,11 +41,6 @@ LayoutUnit NGFragmentBase::BlockOffset() const {
: physical_fragment_->LeftOffset();
}
-NGMarginStrut NGFragmentBase::MarginStrut() const {
- // TODO(layout-ng): Change MarginStrut to support writing direction.
- return physical_fragment_->MarginStrut();
-}
-
DEFINE_TRACE(NGFragmentBase) {
visitor->trace(physical_fragment_);
}

Powered by Google App Engine
This is Rietveld 408576698