Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h

Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal… (Closed)
Patch Set: address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NGFragmentBase_h 5 #ifndef NGFragmentBase_h
6 #define NGFragmentBase_h 6 #define NGFragmentBase_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/layout/ng/ng_physical_constraint_space.h" 9 #include "core/layout/ng/ng_physical_constraint_space.h"
10 #include "core/layout/ng/ng_writing_mode.h" 10 #include "core/layout/ng/ng_writing_mode.h"
(...skipping 18 matching lines...) Expand all
29 LayoutUnit BlockSize() const; 29 LayoutUnit BlockSize() const;
30 30
31 // Returns the total size, including the contents outside of the border-box. 31 // Returns the total size, including the contents outside of the border-box.
32 LayoutUnit InlineOverflow() const; 32 LayoutUnit InlineOverflow() const;
33 LayoutUnit BlockOverflow() const; 33 LayoutUnit BlockOverflow() const;
34 34
35 // Returns the offset relative to the parent fragement's content-box. 35 // Returns the offset relative to the parent fragement's content-box.
36 LayoutUnit InlineOffset() const; 36 LayoutUnit InlineOffset() const;
37 LayoutUnit BlockOffset() const; 37 LayoutUnit BlockOffset() const;
38 38
39 NGMarginStrut MarginStrut() const;
40
41 NGPhysicalFragmentBase* PhysicalFragment() const { 39 NGPhysicalFragmentBase* PhysicalFragment() const {
42 return physical_fragment_; 40 return physical_fragment_;
43 }; 41 };
44 42
45 DECLARE_TRACE(); 43 DECLARE_TRACE();
46 44
47 protected: 45 protected:
48 NGFragmentBase(NGWritingMode writing_mode, 46 NGFragmentBase(NGWritingMode writing_mode,
49 NGDirection direction, 47 NGDirection direction,
50 NGPhysicalFragmentBase* physical_fragment) 48 NGPhysicalFragmentBase* physical_fragment)
51 : physical_fragment_(physical_fragment), 49 : physical_fragment_(physical_fragment),
52 writing_mode_(writing_mode), 50 writing_mode_(writing_mode),
53 direction_(direction) {} 51 direction_(direction) {}
54 52
55 Member<NGPhysicalFragmentBase> physical_fragment_; 53 Member<NGPhysicalFragmentBase> physical_fragment_;
56 54
57 unsigned writing_mode_ : 3; 55 unsigned writing_mode_ : 3;
58 unsigned direction_ : 1; 56 unsigned direction_ : 1;
59 }; 57 };
60 58
61 } // namespace blink 59 } // namespace blink
62 60
63 #endif // NGFragmentBase_h 61 #endif // NGFragmentBase_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_fragment.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698