Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2413983002:
Do not use boolean bitfields in blink::Resource (Closed)
|
Created:
4 years, 2 months ago by yhirano Modified:
4 years, 2 months ago Reviewers:
hiroshige CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDo not use boolean bitfields in blink::Resource
The presubmit script says a class should not have both unsigned an boolean
bitfields[runtime/bitfields].
R=hiroshige@chromium.org
BUG=645395
Committed: https://crrev.com/aa58507933dfd19c9ad4f0d5a9d39cdaf52ad635
Cr-Commit-Position: refs/heads/master@{#426417}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : fix #Patch Set 4 : fix #
Messages
Total messages: 25 (16 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
How about converting all bitfields to non-bitfield members? I feel there is no strong pressure to save the small amount of memory per Resource, as many members have been added to Resource.
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/10/13 06:04:26, hiroshige (OOO) wrote: > How about converting all bitfields to non-bitfield members? > I feel there is no strong pressure to save the small amount of memory per > Resource, as many members have been added to Resource. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Do not use boolean bitfields in blink::Resource The presubmit script says a class should not have both unsigned an boolean bitfields[runtime/bitfields]. R=hiroshige@chromium.org BUG=645395 ========== to ========== Do not use boolean bitfields in blink::Resource The presubmit script says a class should not have both unsigned an boolean bitfields[runtime/bitfields]. R=hiroshige@chromium.org BUG=645395 Committed: https://crrev.com/aa58507933dfd19c9ad4f0d5a9d39cdaf52ad635 Cr-Commit-Position: refs/heads/master@{#426417} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/aa58507933dfd19c9ad4f0d5a9d39cdaf52ad635 Cr-Commit-Position: refs/heads/master@{#426417} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
