Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: third_party/WebKit/Source/core/fetch/Resource.cpp

Issue 2413983002: Do not use boolean bitfields in blink::Resource (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/fetch/Resource.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 6 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
7 rights reserved. 7 rights reserved.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 m_preloadCount(0), 308 m_preloadCount(0),
309 m_preloadDiscoveryTime(0.0), 309 m_preloadDiscoveryTime(0.0),
310 m_cacheIdentifier(MemoryCache::defaultCacheIdentifier()), 310 m_cacheIdentifier(MemoryCache::defaultCacheIdentifier()),
311 m_preloadResult(PreloadNotReferenced), 311 m_preloadResult(PreloadNotReferenced),
312 m_type(type), 312 m_type(type),
313 m_status(NotStarted), 313 m_status(NotStarted),
314 m_needsSynchronousCacheHit(false), 314 m_needsSynchronousCacheHit(false),
315 m_linkPreload(false), 315 m_linkPreload(false),
316 m_isRevalidating(false), 316 m_isRevalidating(false),
317 m_isAlive(false), 317 m_isAlive(false),
318 m_isAddRemoveClientProhibited(false),
318 m_integrityDisposition(ResourceIntegrityDisposition::NotChecked), 319 m_integrityDisposition(ResourceIntegrityDisposition::NotChecked),
319 m_isAddRemoveClientProhibited(false),
320 m_options(options), 320 m_options(options),
321 m_responseTimestamp(currentTime()), 321 m_responseTimestamp(currentTime()),
322 m_cancelTimer(this, &Resource::cancelTimerFired), 322 m_cancelTimer(this, &Resource::cancelTimerFired),
323 m_resourceRequest(request) { 323 m_resourceRequest(request) {
324 // m_type is a bitfield, so this tests careless updates of the enum. 324 // m_type is a bitfield, so this tests careless updates of the enum.
325 DCHECK_EQ(m_type, unsigned(type)); 325 DCHECK_EQ(m_type, unsigned(type));
326 InstanceCounters::incrementCounter(InstanceCounters::ResourceCounter); 326 InstanceCounters::incrementCounter(InstanceCounters::ResourceCounter);
327 327
328 // Currently we support the metadata caching only for HTTP family. 328 // Currently we support the metadata caching only for HTTP family.
329 if (m_resourceRequest.url().protocolIsInHTTPFamily()) 329 if (m_resourceRequest.url().protocolIsInHTTPFamily())
(...skipping 767 matching lines...) Expand 10 before | Expand all | Expand 10 after
1097 case Resource::TextTrack: 1097 case Resource::TextTrack:
1098 case Resource::Media: 1098 case Resource::Media:
1099 case Resource::Manifest: 1099 case Resource::Manifest:
1100 return false; 1100 return false;
1101 } 1101 }
1102 NOTREACHED(); 1102 NOTREACHED();
1103 return false; 1103 return false;
1104 } 1104 }
1105 1105
1106 } // namespace blink 1106 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/fetch/Resource.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698