Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 2413983002: Do not use boolean bitfields in blink::Resource (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 5 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
6 rights reserved. 6 rights reserved.
7 7
8 This library is free software; you can redistribute it and/or 8 This library is free software; you can redistribute it and/or
9 modify it under the terms of the GNU Library General Public 9 modify it under the terms of the GNU Library General Public
10 License as published by the Free Software Foundation; either 10 License as published by the Free Software Foundation; either
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 unsigned m_preloadCount; 412 unsigned m_preloadCount;
413 413
414 double m_preloadDiscoveryTime; 414 double m_preloadDiscoveryTime;
415 415
416 String m_cacheIdentifier; 416 String m_cacheIdentifier;
417 417
418 unsigned m_preloadResult : 2; // PreloadResult 418 unsigned m_preloadResult : 2; // PreloadResult
419 unsigned m_type : 4; // Type 419 unsigned m_type : 4; // Type
420 unsigned m_status : 3; // Status 420 unsigned m_status : 3; // Status
421 421
422 unsigned m_needsSynchronousCacheHit : 1; 422 bool m_needsSynchronousCacheHit;
423 unsigned m_linkPreload : 1; 423 bool m_linkPreload;
424 bool m_isRevalidating : 1; 424 bool m_isRevalidating;
425 bool m_isAlive : 1; 425 bool m_isAlive;
426 bool m_isAddRemoveClientProhibited;
426 427
427 ResourceIntegrityDisposition m_integrityDisposition; 428 ResourceIntegrityDisposition m_integrityDisposition;
428 IntegrityMetadataSet m_integrityMetadata; 429 IntegrityMetadataSet m_integrityMetadata;
429 430
430 bool m_isAddRemoveClientProhibited;
431
432 // Ordered list of all redirects followed while fetching this resource. 431 // Ordered list of all redirects followed while fetching this resource.
433 Vector<RedirectPair> m_redirectChain; 432 Vector<RedirectPair> m_redirectChain;
434 433
435 HeapHashCountedSet<WeakMember<ResourceClient>> m_clients; 434 HeapHashCountedSet<WeakMember<ResourceClient>> m_clients;
436 HeapHashCountedSet<WeakMember<ResourceClient>> m_clientsAwaitingCallback; 435 HeapHashCountedSet<WeakMember<ResourceClient>> m_clientsAwaitingCallback;
437 HeapHashCountedSet<WeakMember<ResourceClient>> m_finishedClients; 436 HeapHashCountedSet<WeakMember<ResourceClient>> m_finishedClients;
438 437
439 ResourceLoaderOptions m_options; 438 ResourceLoaderOptions m_options;
440 439
441 double m_responseTimestamp; 440 double m_responseTimestamp;
(...skipping 23 matching lines...) Expand all
465 }; 464 };
466 465
467 #define DEFINE_RESOURCE_TYPE_CASTS(typeName) \ 466 #define DEFINE_RESOURCE_TYPE_CASTS(typeName) \
468 DEFINE_TYPE_CASTS(typeName##Resource, Resource, resource, \ 467 DEFINE_TYPE_CASTS(typeName##Resource, Resource, resource, \
469 resource->getType() == Resource::typeName, \ 468 resource->getType() == Resource::typeName, \
470 resource.getType() == Resource::typeName); 469 resource.getType() == Resource::typeName);
471 470
472 } // namespace blink 471 } // namespace blink
473 472
474 #endif 473 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698