Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2403193003: Landing Recent QUIC changes until 9:41 AM, Oct 10, 2016 UTC-7 (Closed)

Created:
4 years, 2 months ago by Zhongyi Shi
Modified:
4 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 9:41 AM, Oct 10, 2016 UTC-7 flip flags https://codereview.chromium.org/2409943002/ external-release-note: Adding a flag for enforcement of the single-packet-CHLO policy. Merge internal change: 135685050 https://codereview.chromium.org/2403383002 relnote: Remove rejected packet number from public reset packet. Protected by flag quic_remove_packet_number_from_public_reset. Merge internal change: 135675196 https://codereview.chromium.org/2409013002 Fix PushPromiseWaitCancels to call FireAlarm to cancel the promised stream instead of explicitly call Cancel(). relnote: n/a (test only) Merge internal change: 135621462 https://codereview.chromium.org/2408993002 relnote: n/a (comment only) Modify QuicSpdyStream::FinishedReadingTrailers() doc comment to clarify that method also returns true in the case where there are no trailers (i.e. FIN has been received on the data stream). Merge internal change: 135579382 https://codereview.chromium.org/2408973003 Downgrade some DLOG(INFO) and DLOG(WARNING) in quic_framer.cc to be DVLOG(1) to make the test log less spam. No functional change. relnote: n/a (test log change) Merge internal change: 135517070 https://codereview.chromium.org/2404973003 Enable Expect: 100-continue tests for Autobahn. relnote: n/a test-only change Merge internal change: 135479465 https://codereview.chromium.org/2409933002 Remove unused windowed RTT logic from RttStats relnote: n/a (removing unused code) Merge internal change: 135373698 https://codereview.chromium.org/2404113002 Remove old SendAlgorithmSimulator as unused relnote: n/a (test-only change) Merge internal change: 135371580 https://codereview.chromium.org/2409883002 relnote: Create QUIC connection after it is successfully inserted to the global map. If a connection fails to be insert to the global map, meaning the connection is owned by another silo, toss the packet to that silo. Mostly protected by flag quic_create_session_after_insertion. Merge internal change: 135266510 https://codereview.chromium.org/2407043002 Automated rollback of internal change 130388085. relnote: Rollback flag quic_enforce_mtu_limit. Never enabled. *** Original change description *** Original relnote: Use a small QUIC MTU when a potentially fragmented packet is received. Guarded by quic_enforce_mtu_limit. If QuicRxRing is enabled, the UDP listener will only receive "strange" packets (fragmented, IPv6 extension headers, etc.). If a connection is created from a packet on the UDP listener, shrink the connection's MTU to 1214 for its lifetime. *** Merge internal change: 135261089 https://codereview.chromium.org/2403233003 Changes to testing Peer classes in preparation for Mentat integration This CL moves QuicTimeWaitListManagerPeer into its own library and adds some methods to it, and adds a method to QuicCryptoServerConfigPeer. Both of these changes will be used in an upcoming CL which completes Mentat integration and adds a bunch of dispatcher tests. relnote: n/a test changes only Merge internal change: 135177586 https://codereview.chromium.org/2403743003 relnote: Add a new LazyFack loss detection to QUIC triggered by the LFAK connection option. Flag protected by ENABLED flag quic_enable_lazy_fack. Merge internal change: 135145796 https://codereview.chromium.org/2404003002 Refactoring in preparation for SpdyHeaderBlock cleanup. relnote: Handles more edge cases in SpdyBalsaUtils::RequestHeadersToSpdyHeaders. Not protected. Merge internal change: 135145341 https://codereview.chromium.org/2407003003 relnote: Call QuicBufferedPacketStore::MaybeSetExpirationAlarm instead of setting alarm directly. Merge internal change: 135127082 https://codereview.chromium.org/2403983002 relnote: Deprecate flag quic_no_lower_bw_resumption_limit Merge internal change: 135019838 https://codereview.chromium.org/2408873002 relnote: Remove remaining now unused FEC code from QUIC. Merge internal change: 135007563 https://codereview.chromium.org/2403183002 Add a test to QuicConnectionTest to ensure the ack bundled with a new CHLO includes the packet number currently being processed. relnote: n/a(Test only) Merge internal change: 135004450 https://codereview.chromium.org/2403173002 relnote: Deprecate flag quic_disable_pre_32 Merge internal change: 134981046 https://codereview.chromium.org/2401363004 BUG= Committed: https://crrev.com/7cbefb314906993b65d272f9ee29be10bf8149c9 Cr-Commit-Position: refs/heads/master@{#424501}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+720 lines, -2500 lines) Patch
M net/http/http_stream_factory_impl_job_controller.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M net/net.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/chromium/crypto/proof_source_chromium.cc View 1 2 1 chunk +19 lines, -35 lines 0 comments Download
M net/quic/chromium/crypto/proof_test_chromium.cc View 3 chunks +1 line, -237 lines 0 comments Download
M net/quic/chromium/crypto/proof_verifier_chromium.cc View 1 2 1 chunk +6 lines, -13 lines 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm.cc View 5 chunks +16 lines, -2 lines 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm_test.cc View 1 chunk +67 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/rtt_stats.h View 4 chunks +0 lines, -24 lines 0 comments Download
M net/quic/core/congestion_control/rtt_stats.cc View 4 chunks +1 line, -38 lines 0 comments Download
M net/quic/core/congestion_control/rtt_stats_test.cc View 4 chunks +0 lines, -33 lines 0 comments Download
D net/quic/core/congestion_control/send_algorithm_simulator.h View 1 chunk +0 lines, -245 lines 0 comments Download
D net/quic/core/congestion_control/send_algorithm_simulator.cc View 1 chunk +0 lines, -400 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_bytes.cc View 1 chunk +5 lines, -12 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_bytes_test.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M net/quic/core/crypto/crypto_protocol.h View 2 chunks +2 lines, -5 lines 0 comments Download
M net/quic/core/crypto/proof_source.h View 1 chunk +2 lines, -8 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M net/quic/core/crypto/quic_server_info.cc View 3 chunks +8 lines, -21 lines 0 comments Download
M net/quic/core/quic_buffered_packet_store.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_buffered_packet_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_client_promised_info_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_connection.h View 2 chunks +0 lines, -7 lines 0 comments Download
M net/quic/core/quic_connection.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 2 4 chunks +13 lines, -13 lines 0 comments Download
M net/quic/core/quic_framer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/core/quic_framer.cc View 11 chunks +11 lines, -72 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 1 2 60 chunks +172 lines, -947 lines 0 comments Download
M net/quic/core/quic_packet_creator.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/core/quic_protocol.h View 11 chunks +6 lines, -24 lines 0 comments Download
M net/quic/core/quic_protocol.cc View 8 chunks +14 lines, -37 lines 0 comments Download
M net/quic/core/quic_protocol_test.cc View 9 chunks +27 lines, -51 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_crypto_server_config_peer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_crypto_server_config_peer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 8 chunks +0 lines, -8 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +0 lines, -3 lines 0 comments Download
A net/quic/test_tools/quic_time_wait_list_manager_peer.h View 1 chunk +33 lines, -0 lines 0 comments Download
A net/quic/test_tools/quic_time_wait_list_manager_peer.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 9 chunks +82 lines, -114 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 4 chunks +21 lines, -14 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 2 8 chunks +38 lines, -14 lines 0 comments Download
M net/tools/quic/quic_packet_printer_bin.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_packet_reader.h View 3 chunks +0 lines, -5 lines 0 comments Download
M net/tools/quic/quic_packet_reader.cc View 4 chunks +7 lines, -12 lines 0 comments Download
M net/tools/quic/quic_server.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 2 chunks +1 line, -18 lines 0 comments Download
M net/tools/quic/spdy_balsa_utils.cc View 1 1 chunk +13 lines, -3 lines 0 comments Download
M net/tools/quic/spdy_balsa_utils_test.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.h View 2 chunks +0 lines, -7 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/simple_client.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
Zhongyi Shi
4 years, 2 months ago (2016-10-11 05:26:59 UTC) #9
Ryan Hamilton
lgtm
4 years, 2 months ago (2016-10-11 18:47:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403193003/40001
4 years, 2 months ago (2016-10-11 18:51:43 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-11 19:04:15 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 19:08:08 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7cbefb314906993b65d272f9ee29be10bf8149c9
Cr-Commit-Position: refs/heads/master@{#424501}

Powered by Google App Engine
This is Rietveld 408576698