Landing Recent QUIC changes until 9:41 AM, Oct 10, 2016 UTC-7

net/quic/core/crypto/proof_source.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_CRYPTO_PROOF_SOURCE_H_
 #define NET_QUIC_CRYPTO_PROOF_SOURCE_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 76 matching lines @@
   // The signature uses SHA-256 as the hash function when the key is ECDSA.
   // The signature may use an ECDSA key.
   //
   // |out_chain| is reference counted to avoid the (assumed) expense of copying
   // out the certificates.
   //
   // The number of certificate chains is expected to be small and fixed, thus
   // the ProofSource retains ownership of the contents of |out_chain|. The
   // expectation is that they will be cached forever.
   //
-  // For version before QUIC_VERSION_30, the signature values should be cached
-  // because |server_config| will be somewhat static. However, since they aren't
-  // bounded, the ProofSource may wish to evict entries from that cache, thus
-  // the caller takes ownership of |*out_signature|.
-  //
-  // For QUIC_VERSION_30 and later, the signature depends on |chlo_hash|
-  // which means that the signature can not be cached. The caller takes
-  // ownership of |*out_signature|.
+  // The signature depends on |chlo_hash| which means that the signature can not
+  // be cached. The caller takes ownership of |*out_signature|.
   //
   // |hostname| may be empty to signify that a default certificate should be
   // used.
   //
   // |out_leaf_cert_sct| points to the signed timestamp (RFC6962) of the leaf
   // cert.
   //
   // This function may be called concurrently.
   virtual bool GetProof(const IPAddress& server_ip,
                         const std::string& hostname,
@@ skipping 12 matching lines @@
                         const std::string& hostname,
                         const std::string& server_config,
                         QuicVersion quic_version,
                         base::StringPiece chlo_hash,
                         std::unique_ptr<Callback> callback) = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_CRYPTO_PROOF_SOURCE_H_