chrome/browser/extensions/api/storage/settings_frontend_unittest.cc - Issue 24021002: Propagate more information about ValueStore errors to callers, notably an

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/settings_frontend_unittest.cc

Issue 24021002: Propagate more information about ValueStore errors to callers, notably an (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add Pass*() Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/storage/settings_backend.cc ('k') | chrome/browser/extensions/api/storage/settings_quota_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/settings_frontend_unittest.cc

diff --git a/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc b/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc

index 9eb8e45860957ab0053274c53a26442572b2197b..15e4ff9690e410040b88890082d4c12ddf47911f 100644

--- a/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc

+++ b/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc

@@ -111,7 +111,7 @@ TEST_F(ExtensionSettingsFrontendTest, SettingsPreservedAcrossReconstruction) {

{

ValueStore::ReadResult result = storage->Get();

ASSERT_FALSE(result->HasError());

- EXPECT_FALSE(result->settings()->empty());

+ EXPECT_FALSE(result->settings().empty());

}

ResetFrontend();

@@ -120,7 +120,7 @@ TEST_F(ExtensionSettingsFrontendTest, SettingsPreservedAcrossReconstruction) {

{

ValueStore::ReadResult result = storage->Get();

ASSERT_FALSE(result->HasError());

- EXPECT_FALSE(result->settings()->empty());

+ EXPECT_FALSE(result->settings().empty());

}

@@ -148,7 +148,7 @@ TEST_F(ExtensionSettingsFrontendTest, SettingsClearedOnUninstall) {

{

ValueStore::ReadResult result = storage->Get();

ASSERT_FALSE(result->HasError());

- EXPECT_TRUE(result->settings()->empty());

+ EXPECT_TRUE(result->settings().empty());

}