Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4052)

Unified Diff: chrome/browser/extensions/api/storage/settings_backend.cc

Issue 24021002: Propagate more information about ValueStore errors to callers, notably an (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add Pass*() Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/settings_backend.cc
diff --git a/chrome/browser/extensions/api/storage/settings_backend.cc b/chrome/browser/extensions/api/storage/settings_backend.cc
index cd4976a7b4b737c0b4621cd6c0a8204b37de8254..cf6ccad65dbd4ec2bc8173e838e09e2b152e98c7 100644
--- a/chrome/browser/extensions/api/storage/settings_backend.cc
+++ b/chrome/browser/extensions/api/storage/settings_backend.cc
@@ -160,11 +160,10 @@ syncer::SyncDataList SettingsBackend::GetAllSyncData(
ValueStore::ReadResult maybe_settings = GetStorage(*it)->Get();
if (maybe_settings->HasError()) {
LOG(WARNING) << "Failed to get settings for " << *it << ": " <<
- maybe_settings->error();
+ maybe_settings->error().message;
continue;
}
- AddAllSyncData(*it, *maybe_settings->settings().get(),
- type, &all_sync_data);
+ AddAllSyncData(*it, maybe_settings->settings(), type, &all_sync_data);
}
return all_sync_data;

Powered by Google App Engine
This is Rietveld 408576698