Propagate more information about ValueStore errors to callers, notably an

chrome/browser/extensions/api/storage/settings_frontend_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/stringprintf.h"
@@ skipping 93 matching lines @@
   // be too rigorous.
   {
     StringValue bar("bar");
     ValueStore::WriteResult result = storage->Set(DEFAULTS, "foo", bar);
     ASSERT_FALSE(result->HasError());
   }
 
   {
     ValueStore::ReadResult result = storage->Get();
     ASSERT_FALSE(result->HasError());
-    EXPECT_FALSE(result->settings()->empty());
+    EXPECT_FALSE(result->settings().empty());
   }
 
   ResetFrontend();
   storage = util::GetStorage(id, frontend_.get());
 
   {
     ValueStore::ReadResult result = storage->Get();
     ASSERT_FALSE(result->HasError());
-    EXPECT_FALSE(result->settings()->empty());
+    EXPECT_FALSE(result->settings().empty());
   }
 }
 
 TEST_F(ExtensionSettingsFrontendTest, SettingsClearedOnUninstall) {
   const std::string id = "ext";
   ExtensionServiceInterface* esi =
       extensions::ExtensionSystem::Get(profile_.get())->extension_service();
   static_cast<extensions::settings_test_util::MockExtensionService*>(esi)->
       AddExtensionWithId(id, Manifest::TYPE_LEGACY_PACKAGED_APP);
 
   ValueStore* storage = util::GetStorage(id, frontend_.get());
 
   {
     StringValue bar("bar");
     ValueStore::WriteResult result = storage->Set(DEFAULTS, "foo", bar);
     ASSERT_FALSE(result->HasError());
   }
 
   // This would be triggered by extension uninstall via a DataDeleter.
   frontend_->DeleteStorageSoon(id);
   base::MessageLoop::current()->RunUntilIdle();
 
   // The storage area may no longer be valid post-uninstall, so re-request.
   storage = util::GetStorage(id, frontend_.get());
   {
     ValueStore::ReadResult result = storage->Get();
     ASSERT_FALSE(result->HasError());
-    EXPECT_TRUE(result->settings()->empty());
+    EXPECT_TRUE(result->settings().empty());
   }
 }
 
 TEST_F(ExtensionSettingsFrontendTest, LeveldbDatabaseDeletedFromDiskOnClear) {
   const std::string id = "ext";
   ExtensionServiceInterface* esi =
       extensions::ExtensionSystem::Get(profile_.get())->extension_service();
   static_cast<extensions::settings_test_util::MockExtensionService*>(esi)->
       AddExtensionWithId(id, Manifest::TYPE_EXTENSION);
 
@@ skipping 117 matching lines @@
 
   frontend_->RunWithStorage(
       id, settings::SYNC, base::Bind(&UnlimitedSyncStorageTestCallback));
   frontend_->RunWithStorage(
       id, settings::LOCAL, base::Bind(&UnlimitedLocalStorageTestCallback));
 
   base::MessageLoop::current()->RunUntilIdle();
 }
 
 }  // namespace extensions