Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 23964014: Improve exception messages for detached Range objects. (Closed)

Created:
7 years, 3 months ago by Mike West
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, darktears
Visibility:
Public.

Description

Improve exception messages for detached Range objects. Calling a variety of methods on detached Range objects will throw InvalidStateError. This patch adds some detail to the exception message in the hopes of informing developers about their errors. BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158268

Patch Set 1 #

Patch Set 2 : rebaseline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -39 lines) Patch
M LayoutTests/fast/dom/Range/detach-range-during-deletecontents-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/dom/Range/range-detached-exceptions.html View 1 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Range/range-detached-exceptions-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Range/range-intersectsNode-exception.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/range-intersectsNode-exception-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/range-intersectsNode-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/resources/intersectsNode.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Range.cpp View 1 29 chunks +32 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
Moar exception error message improvements. Mind taking a look, Alexis? -mike
7 years, 3 months ago (2013-09-23 12:22:10 UTC) #1
Mike West
Alexis is blinkon-ing. </jealous> Jochen, mind taking a look? -mike
7 years, 3 months ago (2013-09-24 08:40:19 UTC) #2
jochen (gone - plz use gerrit)
lgtm
7 years, 3 months ago (2013-09-24 09:12:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/23964014/5001
7 years, 3 months ago (2013-09-24 09:17:44 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 12:24:50 UTC) #5
Message was sent while issue was closed.
Change committed as 158268

Powered by Google App Engine
This is Rietveld 408576698