Source/core/dom/Range.h - Issue 23964014: Improve exception messages for detached Range objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Range.h

Issue 23964014: Improve exception messages for detached Range objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebaseline. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Range.h

diff --git a/Source/core/dom/Range.h b/Source/core/dom/Range.h

index 88501446fd7a969dc5af2ea93993dcde0ddd6cfc..82b716c6d1795aaf498e9d7e1ed9993856886816 100644

--- a/Source/core/dom/Range.h

+++ b/Source/core/dom/Range.h

@@ -156,8 +156,8 @@ private:

void setDocument(Document&);

Node* checkNodeWOffset(Node*, int offset, ExceptionState&) const;

- void checkNodeBA(Node*, ExceptionState&, const char* methodName) const;

- void checkDeleteExtract(ExceptionState&);

+ void checkNodeBA(Node*, const String& methodName, ExceptionState&) const;

+ void checkDeleteExtract(const String& methodName, ExceptionState&);

int maxStartOffset() const;

int maxEndOffset() const;

« no previous file with comments | « LayoutTests/fast/dom/Range/resources/intersectsNode.js ('k') | Source/core/dom/Range.cpp » ('j') | no next file with comments »