Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23923010: Move Inspect[BackgroundPage|ExtensionHost] Out of ExtensionService (Closed)

Created:
7 years, 3 months ago by Devlin
Modified:
7 years, 3 months ago
Reviewers:
Finnur, Yoyo Zhou, brettw
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move Inspect[BackgroundPage|ExtensionHost] Out of ExtensionService Move InspectBackgroundPage() and InspectExtensionHost() from ExtensionService into extensions::devtools_util. BUG=157279 TBR=brettw@chromium.org (tab_contents), finnur@chromium.org (webui) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222428

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -44 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
A chrome/browser/extensions/devtools_util.h View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/extensions/devtools_util.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 4 chunks +0 lines, -27 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Devlin
7 years, 3 months ago (2013-09-10 00:49:01 UTC) #1
Yoyo Zhou
LGTM
7 years, 3 months ago (2013-09-10 00:57:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/23923010/3001
7 years, 3 months ago (2013-09-10 18:16:36 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=24720
7 years, 3 months ago (2013-09-10 18:35:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/23923010/3001
7 years, 3 months ago (2013-09-10 18:49:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=75957
7 years, 3 months ago (2013-09-10 22:14:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/23923010/3001
7 years, 3 months ago (2013-09-10 22:19:36 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-11 00:45:40 UTC) #8
Message was sent while issue was closed. 
Change committed as 222428

Powered by Google App Engine
This is Rietveld 408576698