Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4888)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 23923010: Move Inspect[BackgroundPage|ExtensionHost] Out of ExtensionService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 7c9ee4991ee51371739c8bf0df1b24486cd1d4d1..9f437e7fcafd69a3cd401fb7f0d7d3941a5bae86 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -29,7 +29,6 @@
#include "chrome/browser/app_mode/app_mode_utils.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
-#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/extensions/api/app_runtime/app_runtime_api.h"
#include "chrome/browser/extensions/api/declarative/rules_registry_service.h"
#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
@@ -55,7 +54,6 @@
#include "chrome/browser/extensions/external_provider_impl.h"
#include "chrome/browser/extensions/external_provider_interface.h"
#include "chrome/browser/extensions/installed_loader.h"
-#include "chrome/browser/extensions/lazy_background_task_queue.h"
#include "chrome/browser/extensions/management_policy.h"
#include "chrome/browser/extensions/pending_extension_manager.h"
#include "chrome/browser/extensions/permissions_updater.h"
@@ -2967,25 +2965,6 @@ void ExtensionService::SetBackgroundPageReady(const Extension* extension) {
content::NotificationService::NoDetails());
}
-void ExtensionService::InspectBackgroundPage(const Extension* extension) {
- DCHECK(extension);
-
- ExtensionProcessManager* pm = system_->process_manager();
- extensions::LazyBackgroundTaskQueue* queue =
- system_->lazy_background_task_queue();
-
- extensions::ExtensionHost* host =
- pm->GetBackgroundHostForExtension(extension->id());
- if (host) {
- InspectExtensionHost(host);
- } else {
- queue->AddPendingTask(
- profile_, extension->id(),
- base::Bind(&ExtensionService::InspectExtensionHost,
- base::Unretained(this)));
- }
-}
-
bool ExtensionService::IsBeingUpgraded(const Extension* extension) const {
ExtensionRuntimeDataMap::const_iterator it =
extension_runtime_data_.find(extension->id());
@@ -3023,12 +3002,6 @@ void ExtensionService::SetHasUsedWebRequest(const Extension* extension,
extension_runtime_data_[extension->id()].has_used_webrequest = value;
}
-void ExtensionService::InspectExtensionHost(
- extensions::ExtensionHost* host) {
- if (host)
- DevToolsWindow::OpenDevToolsWindow(host->render_view_host());
-}
-
bool ExtensionService::ShouldEnableOnInstall(const Extension* extension) {
// Extensions installed by policy can't be disabled. So even if a previous
// installation disabled the extension, make sure it is now enabled.
« no previous file with comments | « chrome/browser/extensions/extension_service.h ('k') | chrome/browser/tab_contents/render_view_context_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698