chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 23923010: Move Inspect[BackgroundPage|ExtensionHost] Out of ExtensionService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 23923010: Move Inspect[BackgroundPage|ExtensionHost] Out of ExtensionService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index 4e2c9d70fdbf8c4c1b4ebbe90124757d006f7827..ddbfb61052df1fa7cec97cf9431d7851edd7680e 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -22,6 +22,7 @@

#include "chrome/browser/extensions/api/developer_private/developer_private_api_factory.h"

#include "chrome/browser/extensions/api/developer_private/entry_picker.h"

#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"

+#include "chrome/browser/extensions/devtools_util.h"

#include "chrome/browser/extensions/extension_disabled_ui.h"

#include "chrome/browser/extensions/extension_error_reporter.h"

#include "chrome/browser/extensions/extension_service.h"

@@ -733,7 +734,7 @@ bool DeveloperPrivateInspectFunction::RunImpl() {

options.extension_id);

DCHECK(extension);

// Wakes up the background page and opens the inspect window.

- service->InspectBackgroundPage(extension);

+ devtools_util::InspectBackgroundPage(extension, profile());

return false;

}

« no previous file with comments | « no previous file | chrome/browser/extensions/devtools_util.h » ('j') | no next file with comments »