Issue 23923003: Expand RuntimeErrors for ErrorConsole

Issue 23923003: Expand RuntimeErrors for ErrorConsole (Closed)

Created:
7 years, 3 months ago by Devlin

Modified:
7 years, 3 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Expand RuntimeErrors for ErrorConsole Include two of our internal scripts (event_bindings and schemaUtil) as sources for runtime errors. Add tests for same. BUG=21734 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221652

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Copyright fix #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -23 lines)			Patch
M	chrome/browser/extensions/error_console/error_console_browsertest.cc	View		3 chunks	+72 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/error_console/error_console_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/event_router.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View		1 chunk	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/tab_helper.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/dispatcher.cc	View	1	6 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/renderer/extensions/event_unittest.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
A +	chrome/test/data/extensions/error_console/bad_api_arguments_runtime_error/background.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/test/data/extensions/error_console/bad_api_arguments_runtime_error/manifest.json	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/error_console/bad_api_permissions_runtime_error/background.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/test/data/extensions/error_console/bad_api_permissions_runtime_error/manifest.json	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	extensions/browser/extension_error.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	extensions/browser/extension_error.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	extensions/common/extension_urls.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	extensions/common/extension_urls.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

LGTM with nit https://codereview.chromium.org/23923003/diff/16001/chrome/test/data/extensions/error_console/bad_api_arguments_runtime_error/background.js File chrome/test/data/extensions/error_console/bad_api_arguments_runtime_error/background.js (right): https://codereview.chromium.org/23923003/diff/16001/chrome/test/data/extensions/error_console/bad_api_arguments_runtime_error/background.js#newcode1 chrome/test/data/extensions/error_console/bad_api_arguments_runtime_error/background.js:1: // Copyright (c) 2013 The Chromium ...

7 years, 3 months ago (2013-09-04 21:35:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/23923003/23001

7 years, 3 months ago (2013-09-05 23:43:19 UTC) #3

Message was sent while issue was closed.

Change committed as 221652

Expand Messages | Collapse Messages