chrome/browser/extensions/tab_helper.cc - Issue 23923003: Expand RuntimeErrors for ErrorConsole

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/tab_helper.cc

Issue 23923003: Expand RuntimeErrors for ErrorConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Copyright fix Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/tab_helper.cc

diff --git a/chrome/browser/extensions/tab_helper.cc b/chrome/browser/extensions/tab_helper.cc

index 361771852d48ab6a2aea4ac08eb6dbbe0e6f47d2..780b3e6b5ce3aa4d233be6ed0ea71052aca46f88 100644

--- a/chrome/browser/extensions/tab_helper.cc

+++ b/chrome/browser/extensions/tab_helper.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/extensions/tab_helper.h"

#include "base/logging.h"

+#include "base/strings/string_util.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/extensions/activity_log/activity_log.h"

#include "chrome/browser/extensions/api/declarative/rules_registry_service.h"

@@ -364,6 +365,7 @@ void TabHelper::OnDetailedConsoleMessageAdded(

if (IsSourceFromAnExtension(source)) {

ErrorConsole::Get(profile_)->ReportError(

scoped_ptr<ExtensionError>(new RuntimeError(

+ extension_app_ ? extension_app_->id() : EmptyString(),

profile_->IsOffTheRecord(),

source,

message,