Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: extensions/browser/extension_error.cc

Issue 23923003: Expand RuntimeErrors for ErrorConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Copyright fix Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_error.h ('k') | extensions/common/extension_urls.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_error.cc
diff --git a/extensions/browser/extension_error.cc b/extensions/browser/extension_error.cc
index b372885e2dd67676ac773b1093cae143460d8f04..cf7bf49e9b1bbe3dc27d2afb953d559174017d3a 100644
--- a/extensions/browser/extension_error.cc
+++ b/extensions/browser/extension_error.cc
@@ -100,14 +100,15 @@ bool ManifestError::IsEqualImpl(const ExtensionError* rhs) const {
return true;
}
-RuntimeError::RuntimeError(bool from_incognito,
+RuntimeError::RuntimeError(const std::string& extension_id,
+ bool from_incognito,
const string16& source,
const string16& message,
const StackTrace& stack_trace,
const GURL& context_url,
logging::LogSeverity level)
: ExtensionError(ExtensionError::RUNTIME_ERROR,
- GURL(source).host(),
+ !extension_id.empty() ? extension_id : GURL(source).host(),
from_incognito,
level,
source,
« no previous file with comments | « extensions/browser/extension_error.h ('k') | extensions/common/extension_urls.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698