Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23904003: Remove GrRefCnt.h in favor of SkRefCnt.h (Closed)

Created:
7 years, 3 months ago by tfarina
Modified:
7 years, 3 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove GrRefCnt.h in favor of SkRefCnt.h This removes GrRefCnt.h with all its tyepdefs and #defines and just switch them to the Sk* equivalents. GrSafeSetNull was promoted to SkSafeSetNull in SkRefCnt.h. BUG=None TEST=none, no functional changes. R=robertphillips@google.com,bsalomon@google.com Committed: http://code.google.com/p/skia/source/detail?r=11151

Patch Set 1 #

Patch Set 2 : SkSafeUnref #

Patch Set 3 : SkRefCnt_SafeAssign #

Patch Set 4 : SkSafeSetNull #

Patch Set 5 : SkRefCnt #

Patch Set 6 : rm GrRefCnt.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -122 lines) Patch
M gm/texdata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/gpu.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M gyp/public_headers.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkRefCnt.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 3 4 4 chunks +5 lines, -6 lines 0 comments Download
M include/gpu/GrEffect.h View 1 2 3 4 3 chunks +3 lines, -4 lines 0 comments Download
M include/gpu/GrFontScaler.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/GrKey.h View 1 2 3 4 3 chunks +2 lines, -7 lines 0 comments Download
M include/gpu/GrPathRendererChain.h View 1 2 3 4 4 chunks +1 line, -5 lines 0 comments Download
D include/gpu/GrRefCnt.h View 1 2 3 4 5 1 chunk +0 lines, -33 lines 0 comments Download
M include/gpu/GrResource.h View 1 2 3 4 4 chunks +3 lines, -6 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 2 3 4 4 chunks +3 lines, -5 lines 0 comments Download
M src/gpu/GrAARectRenderer.h View 1 2 3 4 3 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrAtlas.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 2 3 4 4 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 3 4 4 chunks +4 lines, -7 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.h View 1 2 3 4 3 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPathRenderer.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextStrike.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGrFontScaler.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLContext.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLTexture.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M tests/ClipCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
search&replace. ptal, thanks.
7 years, 3 months ago (2013-09-09 01:59:04 UTC) #1
bsalomon
lgtm
7 years, 3 months ago (2013-09-09 12:40:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/23904003/11001
7 years, 3 months ago (2013-09-09 12:40:26 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 13:38:58 UTC) #4
Message was sent while issue was closed. 
Change committed as 11151

Powered by Google App Engine
This is Rietveld 408576698