Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 23897003: Properly close the CountOperation value/effect context after leaving the store effect context. (Closed)

Created:
7 years, 3 months ago by Toon Verwaest
Modified:
7 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Properly close the CountOperation value/effect context after leaving the store effect context. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16554

Patch Set 1 #

Patch Set 2 : Ensure that the results are correct #

Patch Set 3 : Ensure we get the right value back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M src/hydrogen.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/post-increment-close-context.js View 1 2 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 3 months ago (2013-09-05 12:15:08 UTC) #1
Jakob Kummerow
LGTM, thanks!
7 years, 3 months ago (2013-09-05 12:32:29 UTC) #2
Toon Verwaest
7 years, 3 months ago (2013-09-05 12:33:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r16554 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698