Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: src/hydrogen.cc

Issue 23897003: Properly close the CountOperation value/effect context after leaving the store effect context. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ensure we get the right value back Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/post-increment-close-context.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 25522e87ec0b128fd4f020486e4fbb06c5162a8a..2692b3f1b8cf1df2f02e4668e793e6643dfb4f28 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -7573,9 +7573,10 @@ void HOptimizedGraphBuilder::VisitCountOperation(CountOperation* expr) {
EffectContext for_effect(this);
Push(object);
Push(after);
- return BuildStoreNamed(expr, expr->id(), expr->position(),
- expr->AssignmentId(), prop, object, after);
+ BuildStoreNamed(expr, expr->id(), expr->position(),
+ expr->AssignmentId(), prop, object, after);
}
+ return ast_context()->ReturnValue(Pop());
}
return BuildStoreNamed(expr, expr->id(), expr->position(),
« no previous file with comments | « no previous file | test/mjsunit/regress/post-increment-close-context.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698