Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: src/hydrogen.cc

Issue 23897003: Properly close the CountOperation value/effect context after leaving the store effect context. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ensure we get the right value back Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/post-increment-close-context.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 7555 matching lines...) Expand 10 before | Expand all | Expand 10 after
7566 after = BuildIncrement(returns_original_input, expr); 7566 after = BuildIncrement(returns_original_input, expr);
7567 7567
7568 if (returns_original_input) { 7568 if (returns_original_input) {
7569 HValue* result = Pop(); 7569 HValue* result = Pop();
7570 HValue* object = Pop(); 7570 HValue* object = Pop();
7571 environment()->SetExpressionStackAt(0, result); 7571 environment()->SetExpressionStackAt(0, result);
7572 { 7572 {
7573 EffectContext for_effect(this); 7573 EffectContext for_effect(this);
7574 Push(object); 7574 Push(object);
7575 Push(after); 7575 Push(after);
7576 return BuildStoreNamed(expr, expr->id(), expr->position(), 7576 BuildStoreNamed(expr, expr->id(), expr->position(),
7577 expr->AssignmentId(), prop, object, after); 7577 expr->AssignmentId(), prop, object, after);
7578 } 7578 }
7579 return ast_context()->ReturnValue(Pop());
7579 } 7580 }
7580 7581
7581 return BuildStoreNamed(expr, expr->id(), expr->position(), 7582 return BuildStoreNamed(expr, expr->id(), expr->position(),
7582 expr->AssignmentId(), prop, object, after); 7583 expr->AssignmentId(), prop, object, after);
7583 } else { 7584 } else {
7584 // Keyed property. 7585 // Keyed property.
7585 if (returns_original_input) Push(graph()->GetConstantUndefined()); 7586 if (returns_original_input) Push(graph()->GetConstantUndefined());
7586 7587
7587 CHECK_ALIVE(VisitForValue(prop->obj())); 7588 CHECK_ALIVE(VisitForValue(prop->obj()));
7588 CHECK_ALIVE(VisitForValue(prop->key())); 7589 CHECK_ALIVE(VisitForValue(prop->key()));
(...skipping 2125 matching lines...) Expand 10 before | Expand all | Expand 10 after
9714 if (ShouldProduceTraceOutput()) { 9715 if (ShouldProduceTraceOutput()) {
9715 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9716 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9716 } 9717 }
9717 9718
9718 #ifdef DEBUG 9719 #ifdef DEBUG
9719 graph_->Verify(false); // No full verify. 9720 graph_->Verify(false); // No full verify.
9720 #endif 9721 #endif
9721 } 9722 }
9722 9723
9723 } } // namespace v8::internal 9724 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/post-increment-close-context.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698