Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 23851005: Change event isn't firing when the user reverts the value of a color/date/time input after JS cha… (Closed)

Created:
7 years, 3 months ago by keishi
Modified:
7 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Change event isn't firing when the user reverts the value of a color/date/time input after JS changed the value Setting the value through the value property wasn't setting the textAsOfLastFormControlChangeEvent. So change events weren't firing when the user changes the value back to the one that was set before JS changed it. TEST=automated. BUG=244065 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157061

Patch Set 1 #

Patch Set 2 : updated test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+513 lines, -71 lines) Patch
A LayoutTests/fast/forms/calendar-picker/date-picker-choose-default-value-after-set-value.html View 1 chunk +49 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/calendar-picker/date-picker-choose-default-value-after-set-value-expected.txt View 1 1 chunk +5 lines, -7 lines 0 comments Download
A LayoutTests/fast/forms/calendar-picker/datetimelocal-picker-choose-default-value-after-set-value.html View 1 chunk +49 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/calendar-picker/datetimelocal-picker-choose-default-value-after-set-value-expected.txt View 1 1 chunk +5 lines, -7 lines 0 comments Download
A LayoutTests/fast/forms/calendar-picker/month-picker-choose-default-value-after-set-value.html View 1 chunk +49 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/calendar-picker/month-picker-choose-default-value-after-set-value-expected.txt View 1 1 chunk +5 lines, -7 lines 0 comments Download
A LayoutTests/fast/forms/calendar-picker/week-picker-choose-default-value-after-set-value.html View 1 chunk +49 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/calendar-picker/week-picker-choose-default-value-after-set-value-expected.txt View 1 1 chunk +5 lines, -7 lines 0 comments Download
A LayoutTests/fast/forms/color/input-color-choose-default-value-after-set-value.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/color/input-color-choose-default-value-after-set-value-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-choose-default-value-after-set-value.html View 1 chunk +46 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-choose-default-value-after-set-value-expected.txt View 1 chunk +6 lines, -8 lines 0 comments Download
A LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-choose-default-value-after-set-value.html View 1 chunk +46 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-choose-default-value-after-set-value-expected.txt View 1 chunk +6 lines, -8 lines 0 comments Download
A LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-choose-default-value-after-set-value.html View 1 chunk +45 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-choose-default-value-after-set-value-expected.txt View 1 chunk +6 lines, -8 lines 0 comments Download
A LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-choose-default-value-after-set-value.html View 1 chunk +44 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-choose-default-value-after-set-value-expected.txt View 1 chunk +6 lines, -8 lines 0 comments Download
A LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-choose-default-value-after-set-value.html View 1 chunk +45 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-choose-default-value-after-set-value-expected.txt View 1 chunk +6 lines, -8 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/TextFieldInputType.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
keishi
7 years, 3 months ago (2013-09-02 02:06:48 UTC) #1
tkent
lgtm
7 years, 3 months ago (2013-09-02 02:14:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/23851005/1
7 years, 3 months ago (2013-09-02 02:18:33 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=3697
7 years, 3 months ago (2013-09-02 03:44:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/23851005/17001
7 years, 3 months ago (2013-09-02 04:43:39 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-02 05:53:39 UTC) #6
Message was sent while issue was closed.
Change committed as 157061

Powered by Google App Engine
This is Rietveld 408576698