Source/core/html/HTMLInputElement.cpp - Issue 23851005: Change event isn't firing when the user reverts the value of a color/date/time input after JS cha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 23851005: Change event isn't firing when the user reverts the value of a color/date/time input after JS cha… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: updated test expectation Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-choose-default-value-after-set-value-expected.txt ('k') | Source/core/html/TextFieldInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index 7c90e1caaaca2340f94aab8b3d8cc597dc59f292..c8a303e6cb47fff042d5490533303a9d81155b92 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -1028,8 +1028,12 @@ void HTMLInputElement::setValue(const String& value, TextFieldEventBehavior even

setLastChangeWasNotUserEdit();

setFormControlValueMatchesRenderer(false);

m_suggestedValue = String(); // Prevent TextFieldInputType::setValue from using the suggested value.

m_inputType->setValue(sanitizedValue, valueChanged, eventBehavior);

+ if (valueChanged && eventBehavior == DispatchNoEvent)

+ setTextAsOfLastFormControlChangeEvent(sanitizedValue);

if (!valueChanged)

return;