Source/core/html/shadow/SliderThumbElement.cpp - Issue 23851005: Change event isn't firing when the user reverts the value of a color/date/time input after JS cha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/SliderThumbElement.cpp

Issue 23851005: Change event isn't firing when the user reverts the value of a color/date/time input after JS cha… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: updated test expectation Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/shadow/SliderThumbElement.cpp

diff --git a/Source/core/html/shadow/SliderThumbElement.cpp b/Source/core/html/shadow/SliderThumbElement.cpp

index d6751cb241becf57d4269faaf292c13e131c45c2..a6a2e4732a713e13230fd4acf5a986e209d4021f 100644

--- a/Source/core/html/shadow/SliderThumbElement.cpp

+++ b/Source/core/html/shadow/SliderThumbElement.cpp

@@ -256,7 +256,6 @@ void SliderThumbElement::setPositionFromPoint(const LayoutPoint& point)

if (!input->renderer() || !renderBox() || !trackElement->renderBox())

return;

- input->setTextAsOfLastFormControlChangeEvent(input->value());

LayoutPoint offset = roundedLayoutPoint(input->renderer()->absoluteToLocal(point, UseTransforms));

bool isVertical = hasVerticalAppearance(input.get());

bool isLeftToRightDirection = renderBox()->style()->isLeftToRightDirection();

« no previous file with comments | « Source/core/html/TextFieldInputType.cpp ('k') | no next file » | no next file with comments »