components/web_modal/web_contents_modal_dialog_manager.h - Issue 23815006: [Cleanup] rename WebContentsModalDialogManager::IsShowingDialog() to IsDialogActive()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.h

Issue 23815006: [Cleanup] rename WebContentsModalDialogManager::IsShowingDialog() to IsDialogActive() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc ('k') | components/web_modal/web_contents_modal_dialog_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_modal/web_contents_modal_dialog_manager.h

diff --git a/components/web_modal/web_contents_modal_dialog_manager.h b/components/web_modal/web_contents_modal_dialog_manager.h

index eff0e2c108096143d0c1a7591311fcd29e50ab7b..58d5520b9fcc05f2801fc95b9a476413c052e96d 100644

--- a/components/web_modal/web_contents_modal_dialog_manager.h

+++ b/components/web_modal/web_contents_modal_dialog_manager.h

@@ -39,12 +39,10 @@ class WebContentsModalDialogManager

void ShowDialog(NativeWebContentsModalDialog dialog);

// Returns true if any dialogs are active and not closed.

- // TODO(wittman): Give this a better name, since it can return true if no

- // dialogs are displayed.

- bool IsShowingDialog() const;

+ bool IsDialogActive() const;

- // Focus the topmost modal dialog. IsShowingDialog() must be true when

- // calling this function.

+ // Focus the topmost modal dialog. IsDialogActive() must be true when calling

+ // this function.

void FocusTopmostDialog();

// Set to true to close the window when a page load starts on the WebContents.