Use hide_scrollbars setting for Android WebView.

Use hide_scrollbars setting for Android WebView.

Removes the original logic to disable scrollbars from the compositor and replaces it with configuring the new WebPreference for blink.

BUG=639806
Committed: https://crrev.com/3d4d1a3324c680f6ef88deee59b25418c87be660
Cr-Commit-Position: refs/heads/master@{#422219}

[Eric Seckler, 2016-09-29 09:04:08]

Description was changed from

==========
Use hide_scrollbars setting for Android WebView.

BUG=639806
==========

to

==========
Use hide_scrollbars setting for Android WebView.

Removes the original logic to disable scrollbars from the compositor and
replaces it with configuring the new WebPreference for blink.

BUG=639806
==========

[Eric Seckler, 2016-09-29 09:07:53]

eseckler@chromium.org changed reviewers:
+ aelias@chromium.org, torne@chromium.org

[Eric Seckler, 2016-09-29 09:07:54]

Hey Alex, Torne,

I managed to verify that scrollbars are still hidden in android_webview_apk, but
failed in replacing the system webview on my device, so can't verify that system
scrollbars still show up. I'll ping Torne offline to figure out what I'm doing
wrong... :)

Cheers,
Eric

[Torne, 2016-09-29 12:45:57]

android_webview change LGTM, but I'd like to know it's been tested on the real
webview before we land it. Grab me whenever you have some time and I'll help you
build and install webview locally.

[Eric Seckler, 2016-09-29 16:02:04]

On 2016/09/29 12:45:57, Torne wrote:
> android_webview change LGTM, but I'd like to know it's been tested on the real
> webview before we land it. Grab me whenever you have some time and I'll help
you
> build and install webview locally.

Thanks for helping out, Torne!

The system scrollbars still show up in the system webview shell, so visibility
of scrollbars is as expected.

However, I discovered that there's an issue with iFrames, which are not
user-scrollable when hide_scrollbars=true. There's a patch out to fix this:
https://codereview.chromium.org/2377283003/.
Once the fix is landed, this should be good to go, too.
in_reply_to: 5724160613416960
send_mail: 1
subject: Use hide_scrollbars setting for Android WebView.

[Eric Seckler, 2016-09-29 16:04:18]

The CQ bit was checked by eseckler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 16:04:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 17:10:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 17:10:18]

Dry run: Exceeded global retry quota

[aelias_OOO_until_Jul13, 2016-09-29 18:38:56]

Note that trybots report this causes
android_webview.test.AndroidScrollIntegrationTest to fail.    (Possibly this is
due to what you're fixing in https://codereview.chromium.org/2377283003/, but
I'm not certain.)

[Eric Seckler, 2016-09-29 19:00:55]

The CQ bit was checked by eseckler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 19:01:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Seckler, 2016-09-29 19:43:55]

On 2016/09/29 18:38:56, aelias wrote:
> Note that trybots report this causes
> android_webview.test.AndroidScrollIntegrationTest to fail.    (Possibly this
is
> due to what you're fixing in https://codereview.chromium.org/2377283003/, but
> I'm not certain.)

Uploaded a revision that integrates the scroll fix from
https://codereview.chromium.org/2377283003/, looks like the trybots pass now :)

[commit-bot: I haz the power, 2016-09-29 20:11:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 20:11:14]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2016-09-29 20:27:13]

lgtm

[Eric Seckler, 2016-09-30 19:11:58]

The CQ bit was unchecked by eseckler@chromium.org

[Eric Seckler, 2016-09-30 19:11:58]

The CQ bit was checked by eseckler@chromium.org

[Eric Seckler, 2016-09-30 19:11:59]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2380963002/#ps20001
(title: "Add dependency to patch fixing frame scrolling.")

[commit-bot: I haz the power, 2016-09-30 19:12:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 21:14:00]

Description was changed from

==========
Use hide_scrollbars setting for Android WebView.

Removes the original logic to disable scrollbars from the compositor and
replaces it with configuring the new WebPreference for blink.

BUG=639806
==========

to

==========
Use hide_scrollbars setting for Android WebView.

Removes the original logic to disable scrollbars from the compositor and
replaces it with configuring the new WebPreference for blink.

BUG=639806
==========

[commit-bot: I haz the power, 2016-09-30 21:14:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 21:16:13]

Description was changed from

==========
Use hide_scrollbars setting for Android WebView.

Removes the original logic to disable scrollbars from the compositor and
replaces it with configuring the new WebPreference for blink.

BUG=639806
==========

to

==========
Use hide_scrollbars setting for Android WebView.

Removes the original logic to disable scrollbars from the compositor and
replaces it with configuring the new WebPreference for blink.

BUG=639806

Committed: https://crrev.com/3d4d1a3324c680f6ef88deee59b25418c87be660
Cr-Commit-Position: refs/heads/master@{#422219}
==========

[commit-bot: I haz the power, 2016-09-30 21:16:15]

Patchset 2 (id:??) landed as
https://crrev.com/3d4d1a3324c680f6ef88deee59b25418c87be660
Cr-Commit-Position: refs/heads/master@{#422219}