Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2377283003:
Don't use ScrollbarAlwaysOff for hide_scrollbars. (Closed)
|
Created:
4 years, 2 months ago by Eric Seckler Modified:
4 years, 2 months ago CC:
aelias_OOO_until_Jul13, blink-reviews, chromium-reviews, Torne Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't use ScrollbarAlwaysOff for hide_scrollbars.
Currently we use ScrollbarAlwaysOff to hide scrollbars in FrameView, but this also has the side effect that users can't scroll the frame anymore (userScrollable() checks the scrollbar modes). Instead, we now enforce the hide_scrollbars setting in setHasHorizontal/VerticalScrollbar().
BUG=639806
Committed: https://crrev.com/8df0b84f79a9f4eb95f6acbd5c7e5fb1a1adc1fd
Cr-Commit-Position: refs/heads/master@{#422169}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 21 (13 generated)
Description was changed from ========== Don't use ScrollbarAlwaysOff for hide_scrollbars. BUG= ========== to ========== Don't use ScrollbarAlwaysOff for hide_scrollbars. Currently we use ScrollbarAlwaysOff to hide scrollbars in FrameView, but this also has the side effect that users can't scroll the frame anymore (userScrollable() checks the scrollbar modes). Instead, we now enforce the hide_scrollbars setting in setHasHorizontal/VerticalScrollbar(). BUG=639806 ==========
eseckler@chromium.org changed reviewers: + skobes@chromium.org
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
aelias@chromium.org changed reviewers: + aelias@chromium.org
lgtm for WebView's purposes, still needs OWNERS review from skobes@ though.
lgtm
The CQ bit was checked by eseckler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by eseckler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Don't use ScrollbarAlwaysOff for hide_scrollbars. Currently we use ScrollbarAlwaysOff to hide scrollbars in FrameView, but this also has the side effect that users can't scroll the frame anymore (userScrollable() checks the scrollbar modes). Instead, we now enforce the hide_scrollbars setting in setHasHorizontal/VerticalScrollbar(). BUG=639806 ========== to ========== Don't use ScrollbarAlwaysOff for hide_scrollbars. Currently we use ScrollbarAlwaysOff to hide scrollbars in FrameView, but this also has the side effect that users can't scroll the frame anymore (userScrollable() checks the scrollbar modes). Instead, we now enforce the hide_scrollbars setting in setHasHorizontal/VerticalScrollbar(). BUG=639806 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Don't use ScrollbarAlwaysOff for hide_scrollbars. Currently we use ScrollbarAlwaysOff to hide scrollbars in FrameView, but this also has the side effect that users can't scroll the frame anymore (userScrollable() checks the scrollbar modes). Instead, we now enforce the hide_scrollbars setting in setHasHorizontal/VerticalScrollbar(). BUG=639806 ========== to ========== Don't use ScrollbarAlwaysOff for hide_scrollbars. Currently we use ScrollbarAlwaysOff to hide scrollbars in FrameView, but this also has the side effect that users can't scroll the frame anymore (userScrollable() checks the scrollbar modes). Instead, we now enforce the hide_scrollbars setting in setHasHorizontal/VerticalScrollbar(). BUG=639806 Committed: https://crrev.com/8df0b84f79a9f4eb95f6acbd5c7e5fb1a1adc1fd Cr-Commit-Position: refs/heads/master@{#422169} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8df0b84f79a9f4eb95f6acbd5c7e5fb1a1adc1fd Cr-Commit-Position: refs/heads/master@{#422169}
Message was sent while issue was closed.
Patchset #2 (id:20001) has been deleted |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
