Source/testing/runner/TestRunner.cpp - Issue 23788005: Remove calls to HandleScope default ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/testing/runner/TestRunner.cpp

Issue 23788005: Remove calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: code review (pfeldman) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/testing/runner/TestRunner.cpp

diff --git a/Source/testing/runner/TestRunner.cpp b/Source/testing/runner/TestRunner.cpp

index 1778f83bd8b9cb5a523a4b8dcc17bb0993a65906..e527fe07b6bc358a01f6c68ef66ee652cd6cc0d6 100644

--- a/Source/testing/runner/TestRunner.cpp

+++ b/Source/testing/runner/TestRunner.cpp

@@ -1171,7 +1171,7 @@ void TestRunner::setDomainRelaxationForbiddenForURLScheme(const CppArgumentList&

void TestRunner::evaluateScriptInIsolatedWorldAndReturnValue(const CppArgumentList& arguments, CppVariant* result)

{

- v8::HandleScope scope;

+ v8::HandleScope scope(v8::Isolate::GetCurrent());

WebVector<v8::Local<v8::Value> > values;

if (arguments.size() >= 2 && arguments[0].isNumber() && arguments[1].isString()) {

WebScriptSource source(cppVariantToWebString(arguments[1]));