Source/web/InspectorFrontendClientImpl.cpp - Issue 23788005: Remove calls to HandleScope default ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/InspectorFrontendClientImpl.cpp

Issue 23788005: Remove calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: code review (pfeldman) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/InspectorFrontendClientImpl.cpp

diff --git a/Source/web/InspectorFrontendClientImpl.cpp b/Source/web/InspectorFrontendClientImpl.cpp

index 60e1eb24f53ee1bd4e6025f7e9c6170125b5b02e..d1d0c76d7eb399a4851a3098b7ee466bc9c029df 100644

--- a/Source/web/InspectorFrontendClientImpl.cpp

+++ b/Source/web/InspectorFrontendClientImpl.cpp

@@ -63,7 +63,7 @@ InspectorFrontendClientImpl::~InspectorFrontendClientImpl()

void InspectorFrontendClientImpl::windowObjectCleared()

{

- v8::HandleScope handleScope;

+ v8::HandleScope handleScope(v8::Isolate::GetCurrent());

v8::Handle<v8::Context> frameContext = m_frontendPage->mainFrame() ? m_frontendPage->mainFrame()->script()->currentWorldContext() : v8::Local<v8::Context>();

v8::Context::Scope contextScope(frameContext);

« no previous file with comments | « Source/testing/runner/TestRunner.cpp ('k') | Source/web/WebBindings.cpp » ('j') | no next file with comments »