Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: Source/core/testing/v8/WebCoreTestSupport.cpp

Issue 23788005: Remove calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: code review (pfeldman) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/ScriptProfile.cpp ('k') | Source/testing/runner/TestRunner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/v8/WebCoreTestSupport.cpp
diff --git a/Source/core/testing/v8/WebCoreTestSupport.cpp b/Source/core/testing/v8/WebCoreTestSupport.cpp
index e48d100e7db33b519d8687e39f4dbaaa1642c769..e18e3694d455faed23993ed02f803a2dedfb0dc7 100644
--- a/Source/core/testing/v8/WebCoreTestSupport.cpp
+++ b/Source/core/testing/v8/WebCoreTestSupport.cpp
@@ -42,8 +42,7 @@ namespace WebCoreTestSupport {
void injectInternalsObject(v8::Local<v8::Context> context)
{
v8::Context::Scope contextScope(context);
- v8::HandleScope scope;
-
+ v8::HandleScope scope(context->GetIsolate());
ScriptExecutionContext* scriptContext = getScriptExecutionContext();
if (scriptContext->isDocument())
context->Global()->Set(v8::String::New(Internals::internalsId), toV8(Internals::create(toDocument(scriptContext)), v8::Handle<v8::Object>(), context->GetIsolate()));
@@ -56,7 +55,7 @@ void resetInternalsObject(v8::Local<v8::Context> context)
return;
v8::Context::Scope contextScope(context);
- v8::HandleScope scope;
+ v8::HandleScope scope(context->GetIsolate());
ScriptExecutionContext* scriptContext = getScriptExecutionContext();
Page* page = toDocument(scriptContext)->frame()->page();
« no previous file with comments | « Source/core/inspector/ScriptProfile.cpp ('k') | Source/testing/runner/TestRunner.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698