Source/bindings/v8/ScriptString.cpp - Issue 23788005: Remove calls to HandleScope default ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptString.cpp

Issue 23788005: Remove calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: code review (pfeldman) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptString.cpp

diff --git a/Source/bindings/v8/ScriptString.cpp b/Source/bindings/v8/ScriptString.cpp

index b031856cec833c65807a8f5467064ed365dc129f..d97a77aaf754015161d62f95fbbe3292ebd233f3 100644

--- a/Source/bindings/v8/ScriptString.cpp

+++ b/Source/bindings/v8/ScriptString.cpp

@@ -48,7 +48,7 @@ String ScriptString::flattenToString() const

{

if (hasNoValue())

return String();

- v8::HandleScope handleScope;

+ v8::HandleScope handleScope(v8::Isolate::GetCurrent());

v8::Handle<v8::String> value = v8::Handle<v8::String>::Cast(v8Value());

return v8StringToWebCoreString<String>(value, Externalize);

}

« no previous file with comments | « Source/bindings/v8/ScriptState.cpp ('k') | Source/bindings/v8/SerializedScriptValue.cpp » ('j') | no next file with comments »