Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: Source/bindings/v8/ScriptState.cpp

Issue 23788005: Remove calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: code review (pfeldman) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptState.h ('k') | Source/bindings/v8/ScriptString.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptState.cpp
diff --git a/Source/bindings/v8/ScriptState.cpp b/Source/bindings/v8/ScriptState.cpp
index 516eb947684052231e0beae141d114e40244617f..e7856417c0db1b417fbb70d9f62e4ec69dd6ac40 100644
--- a/Source/bindings/v8/ScriptState.cpp
+++ b/Source/bindings/v8/ScriptState.cpp
@@ -83,8 +83,9 @@ ScriptState* ScriptState::forContext(v8::Handle<v8::Context> context)
ScriptState* ScriptState::current()
{
- v8::HandleScope handleScope;
- v8::Local<v8::Context> context = v8::Context::GetCurrent();
+ v8::Isolate* isolate = v8::Isolate::GetCurrent();
+ v8::HandleScope handleScope(isolate);
+ v8::Local<v8::Context> context = isolate->GetCurrentContext();
ASSERT(!context.IsEmpty());
return ScriptState::forContext(context);
}
@@ -108,7 +109,7 @@ void ScriptState::setEvalEnabled(bool enabled)
ScriptState* mainWorldScriptState(Frame* frame)
{
- v8::HandleScope handleScope;
+ v8::HandleScope handleScope(frame->script()->isolate());
return ScriptState::forContext(frame->script()->mainWorldContext());
}
@@ -118,7 +119,7 @@ ScriptState* scriptStateFromWorkerGlobalScope(WorkerGlobalScope* workerGlobalSco
if (!script)
return 0;
- v8::HandleScope handleScope;
+ v8::HandleScope handleScope(script->isolate());
return ScriptState::forContext(script->context());
}
« no previous file with comments | « Source/bindings/v8/ScriptState.h ('k') | Source/bindings/v8/ScriptString.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698