Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: Source/bindings/v8/SerializedScriptValue.cpp

Issue 23788005: Remove calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: code review (pfeldman) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptString.cpp ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/SerializedScriptValue.cpp
diff --git a/Source/bindings/v8/SerializedScriptValue.cpp b/Source/bindings/v8/SerializedScriptValue.cpp
index 5a0c0d8551b14ff1668f7cdff18f97bf1f771b5f..5503351b69d2cc926f75e008cffc7085117b5da5 100644
--- a/Source/bindings/v8/SerializedScriptValue.cpp
+++ b/Source/bindings/v8/SerializedScriptValue.cpp
@@ -1985,7 +1985,7 @@ public:
if (!m_reader.readVersion(m_version) || m_version > wireFormatVersion)
return v8NullWithCheck(m_reader.getIsolate());
m_reader.setVersion(m_version);
- v8::HandleScope scope;
+ v8::HandleScope scope(m_reader.getIsolate());
while (!m_reader.isEof()) {
if (!doDeserialize())
return v8NullWithCheck(m_reader.getIsolate());
@@ -2507,7 +2507,7 @@ v8::Handle<v8::Value> SerializedScriptValue::deserialize(v8::Isolate* isolate, M
ScriptValue SerializedScriptValue::deserializeForInspector(ScriptState* scriptState)
{
- v8::HandleScope handleScope;
+ v8::HandleScope handleScope(scriptState->isolate());
v8::Context::Scope contextScope(scriptState->context());
return ScriptValue(deserialize(scriptState->isolate()));
« no previous file with comments | « Source/bindings/v8/ScriptString.cpp ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698