Source/bindings/v8/ScriptState.h - Issue 23788005: Remove calls to HandleScope default ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptState.h

Issue 23788005: Remove calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: code review (pfeldman) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptState.h

diff --git a/Source/bindings/v8/ScriptState.h b/Source/bindings/v8/ScriptState.h

index 16a4a4a5ccbc16338997adda8e4a8896f34b2b53..b6f7e37914e3771aaacc3def141d37205dc37e42 100644

--- a/Source/bindings/v8/ScriptState.h

+++ b/Source/bindings/v8/ScriptState.h

@@ -109,7 +109,7 @@ public:

ScriptStateProtectedPtr(ScriptState* scriptState)

: m_scriptState(scriptState)

{

- v8::HandleScope handleScope;

+ v8::HandleScope handleScope(scriptState->isolate());

// Keep the context from being GC'ed. ScriptState is guaranteed to be live while the context is live.

m_context.set(scriptState->isolate(), scriptState->context());

}

« no previous file with comments | « Source/bindings/v8/ScriptScope.cpp ('k') | Source/bindings/v8/ScriptState.cpp » ('j') | no next file with comments »