Refactor TransformPoint{,Reverse}.

Refactor TransformPoint{,Reverse}.

These methods now take pointers instead of non-const references, this was
previously a violation of the style guide.

R=vollick@chromium.org
BUG=160417
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222864

[tfarina, 2013-09-09 23:41:08]

I've filed a bug for this. Let me get the number

[tfarina, 2013-09-09 23:42:03]

See crbug.com/160417, please, update your BUG= line to refer to it. Thanks.

[Ian Vollick, 2013-09-11 12:27:23]

On 2013/09/09 23:42:03, tfarina wrote:
> See crbug.com/160417, please, update your BUG= line to refer to it. Thanks.

lgtm, but you'll need an OWNER for ash/, ui/base/, ui/aura, and webkit/

[avallee, 2013-09-11 14:04:09]

enne@chromium.org: Please review changes in 

/ash, /ui/{aura,base,views}

sky@chromium.org: Please review changes in 

blink

[avallee, 2013-09-11 14:24:17]

Sorry, got that the wrong way around.


On Wed, Sep 11, 2013 at 10:04 AM, <avallee@chromium.org> wrote:

> enne@chromium.org: Please review changes in
>
blink

>
> sky@chromium.org: Please review changes in
>
/ash, /ui/{aura,base,views}

>
>
>
>
>
>
https://codereview.chromium.**org/23724024/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2013-09-11 16:29:33]

LGTM

[enne (OOO), 2013-09-12 17:33:15]

webkit/ lgtm

[commit-bot: I haz the power, 2013-09-12 17:45:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avallee@chromium.org/23724024/1

[commit-bot: I haz the power, 2013-09-12 17:45:46]

Failed to apply patch for ui/gfx/transform.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ui/gfx/transform.cc
  Hunk #1 succeeded at 369 with fuzz 1 (offset -6 lines).
  Hunk #2 succeeded at 391 (offset -6 lines).
  Hunk #3 FAILED at 449.
  1 out of 3 hunks FAILED -- saving rejects to file ui/gfx/transform.cc.rej

Patch:       ui/gfx/transform.cc
Index: ui/gfx/transform.cc
diff --git a/ui/gfx/transform.cc b/ui/gfx/transform.cc
index
3e94f44e21cb37c012d201c3ec0d58b40ca44b60..f56082cf2a3cdc717039f643bc8311db809d8010
100644
--- a/ui/gfx/transform.cc
+++ b/ui/gfx/transform.cc
@@ -375,15 +375,19 @@ Vector2dF Transform::To2dTranslation() const {
   return gfx::Vector2dF(matrix_.getDouble(0, 3), matrix_.getDouble(1, 3));
 }
 
-void Transform::TransformPoint(Point& point) const {
+void Transform::TransformPoint(Point* point) const {
+  DCHECK(point);
   TransformPointInternal(matrix_, point);
 }
 
-void Transform::TransformPoint(Point3F& point) const {
+void Transform::TransformPoint(Point3F* point) const {
+  DCHECK(point);
   TransformPointInternal(matrix_, point);
 }
 
-bool Transform::TransformPointReverse(Point& point) const {
+bool Transform::TransformPointReverse(Point* point) const {
+  DCHECK(point);
+
   // TODO(sad): Try to avoid trying to invert the matrix.
   SkMatrix44 inverse(SkMatrix44::kUninitialized_Constructor);
   if (!matrix_.invert(&inverse))
@@ -393,7 +397,9 @@ bool Transform::TransformPointReverse(Point& point) const {
   return true;
 }
 
-bool Transform::TransformPointReverse(Point3F& point) const {
+bool Transform::TransformPointReverse(Point3F* point) const {
+  DCHECK(point);
+
   // TODO(sad): Try to avoid trying to invert the matrix.
   SkMatrix44 inverse(SkMatrix44::kUninitialized_Constructor);
   if (!matrix_.invert(&inverse))
@@ -443,41 +449,41 @@ bool Transform::Blend(const Transform& from, double
progress) {
 }
 
 void Transform::TransformPointInternal(const SkMatrix44& xform,
-                                       Point3F& point) const {
+                                       Point3F* point) const {
   if (xform.isIdentity())
     return;
 
   SkMScalar p[4] = {
-    SkDoubleToMScalar(point.x()),
-    SkDoubleToMScalar(point.y()),
-    SkDoubleToMScalar(point.z()),
+    SkDoubleToMScalar(point->x()),
+    SkDoubleToMScalar(point->y()),
+    SkDoubleToMScalar(point->z()),
     SkDoubleToMScalar(1)
   };
 
   xform.mapMScalars(p);
 
   if (p[3] != 1 && abs(p[3]) > 0) {
-    point.SetPoint(p[0] / p[3], p[1] / p[3], p[2]/ p[3]);
+    point->SetPoint(p[0] / p[3], p[1] / p[3], p[2]/ p[3]);
   } else {
-    point.SetPoint(p[0], p[1], p[2]);
+    point->SetPoint(p[0], p[1], p[2]);
   }
 }
 
 void Transform::TransformPointInternal(const SkMatrix44& xform,
-                                       Point& point) const {
+                                       Point* point) const {
   if (xform.isIdentity())
     return;
 
   SkMScalar p[4] = {
-    SkDoubleToMScalar(point.x()),
-    SkDoubleToMScalar(point.y()),
+    SkDoubleToMScalar(point->x()),
+    SkDoubleToMScalar(point->y()),
     SkDoubleToMScalar(0),
     SkDoubleToMScalar(1)
   };
 
   xform.mapMScalars(p);
 
-  point.SetPoint(ToRoundedInt(p[0]), ToRoundedInt(p[1]));
+  point->SetPoint(ToRoundedInt(p[0]), ToRoundedInt(p[1]));
 }
 
 std::string Transform::ToString() const {

[commit-bot: I haz the power, 2013-09-12 18:05:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avallee@chromium.org/23724024/19001

[commit-bot: I haz the power, 2013-09-12 20:59:50]

Change committed as 222864