Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1644)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/views/view.cc

Issue 23724024: Refactor TransformPoint{,Reverse}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and resolve conflicts. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/transform_util_unittest.cc ('k') | webkit/renderer/compositor_bindings/web_layer_impl_fixed_bounds_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/view.cc
diff --git a/ui/views/view.cc b/ui/views/view.cc
index 81f0207bec7cfd07fc2ef3beefb6f6becada10a8..14238ca519c67d187121dfbc49d5d31b4903d0e1 100644
--- a/ui/views/view.cc
+++ b/ui/views/view.cc
@@ -1999,7 +1999,7 @@ bool View::ConvertPointForAncestor(const View* ancestor,
// TODO(sad): Have some way of caching the transformation results.
bool result = GetTransformRelativeTo(ancestor, &trans);
gfx::Point3F p(*point);
- trans.TransformPoint(p);
+ trans.TransformPoint(&p);
*point = gfx::ToFlooredPoint(p.AsPointF());
return result;
}
@@ -2009,7 +2009,7 @@ bool View::ConvertPointFromAncestor(const View* ancestor,
gfx::Transform trans;
bool result = GetTransformRelativeTo(ancestor, &trans);
gfx::Point3F p(*point);
- trans.TransformPointReverse(p);
+ trans.TransformPointReverse(&p);
*point = gfx::ToFlooredPoint(p.AsPointF());
return result;
}
« no previous file with comments | « ui/gfx/transform_util_unittest.cc ('k') | webkit/renderer/compositor_bindings/web_layer_impl_fixed_bounds_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698