Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 23702007: Render inband text tracks in the media pipeline (Closed)

Created:
7 years, 3 months ago by Matthew Heaney (Chromium)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Render inband text tracks in the media pipeline This change modifies the FFmpeg demuxer to recognize text streams embedded in the source media (Webm). Text decoder and text renderer filters have been added to the pipeline, to process the text frames as they are pulled downstream. BUG=230708 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236660

Patch Set 1 #

Total comments: 106

Patch Set 2 : incorporate aaron's comments #

Patch Set 3 : incorporated more of aaron's comments #

Total comments: 16

Patch Set 4 : incorporate aaron's comments (9/28) #

Total comments: 74

Patch Set 5 : incorporate aaron's comments (10/12) #

Total comments: 60

Patch Set 6 : incorporate aaron's comments (10/16) #

Total comments: 83

Patch Set 7 : incorporate aaron's comments (10/22) #

Total comments: 44

Patch Set 8 : incorporate aaron's comments (10/26)" #

Patch Set 9 : modified ffmpeg demuxer unittest #

Total comments: 30

Patch Set 10 : incorporate aaron's comments (11/04) #

Total comments: 32

Patch Set 11 : incorporate aaron's comments (11/12) #

Total comments: 34

Patch Set 12 : incorporate aaron's comments 11/19 #

Patch Set 13 : fix compile errors 11/20 #1 #

Patch Set 14 : fix compile errors 11/20 #2 #

Patch Set 15 : fix compile errors 11/20 #3 #

Total comments: 2

Patch Set 16 : fix compile errors 11/21 #4 #

Patch Set 17 : fix compile errors 11/21 #5 #

Patch Set 18 : fix compile errors 11/21 #6 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3331 lines, -365 lines) Patch
M content/renderer/media/android/media_source_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 4 chunks +15 lines, -9 lines 0 comments Download
M content/renderer/media/texttrack_impl.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +19 lines, -2 lines 0 comments Download
M content/renderer/media/texttrack_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +39 lines, -6 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +28 lines, -21 lines 0 comments Download
M media/base/demuxer.h View 1 2 3 4 5 6 7 8 9 4 chunks +13 lines, -2 lines 0 comments Download
M media/base/demuxer_perftest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +6 lines, -2 lines 0 comments Download
M media/base/demuxer_stream.h View 6 7 1 chunk +1 line, -0 lines 0 comments Download
A media/base/fake_text_track_stream.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +47 lines, -0 lines 0 comments Download
A media/base/fake_text_track_stream.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +83 lines, -0 lines 0 comments Download
M media/base/filter_collection.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/base/filter_collection.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M media/base/media_log.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/media_log_event.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/mock_demuxer_host.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -2 lines 0 comments Download
M media/base/mock_filters.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +18 lines, -1 line 0 comments Download
M media/base/mock_filters.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download
M media/base/pipeline.h View 1 2 3 4 5 6 7 7 chunks +19 lines, -3 lines 0 comments Download
M media/base/pipeline.cc View 1 2 3 4 5 6 7 8 9 10 11 14 chunks +79 lines, -1 line 0 comments Download
M media/base/pipeline_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 17 chunks +100 lines, -8 lines 0 comments Download
M media/base/stream_parser.h View 1 2 3 4 5 6 7 8 9 5 chunks +10 lines, -5 lines 0 comments Download
A media/base/text_cue.h View 1 2 3 4 5 6 7 1 chunk +48 lines, -0 lines 0 comments Download
A media/base/text_cue.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download
A media/base/text_renderer.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +145 lines, -0 lines 0 comments Download
A media/base/text_renderer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +369 lines, -0 lines 0 comments Download
A media/base/text_renderer_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1382 lines, -0 lines 0 comments Download
M media/base/text_track.h View 1 2 3 4 5 6 7 2 chunks +7 lines, -12 lines 0 comments Download
A media/base/text_track_config.h View 1 2 3 4 5 6 7 1 chunk +45 lines, -0 lines 0 comments Download
A media/base/text_track_config.cc View 1 2 3 4 5 6 7 1 chunk +27 lines, -0 lines 0 comments Download
M media/filters/chunk_demuxer.h View 1 2 3 4 5 6 7 8 9 4 chunks +7 lines, -8 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 2 3 4 5 6 7 8 9 10 11 30 chunks +203 lines, -49 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 26 chunks +172 lines, -45 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 2 3 4 5 6 7 8 9 5 chunks +16 lines, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 2 3 4 5 6 7 8 9 10 10 chunks +105 lines, -34 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 9 chunks +129 lines, -5 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +2 lines, -9 lines 0 comments Download
M media/filters/source_buffer_stream.h View 1 2 3 4 5 6 7 8 9 4 chunks +7 lines, -0 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +25 lines, -0 lines 0 comments Download
A media/filters/webvtt_util.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +30 lines, -0 lines 0 comments Download
M media/media.gyp View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +10 lines, -0 lines 0 comments Download
M media/mp2t/mp2t_stream_parser.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M media/mp2t/mp2t_stream_parser.cc View 1 2 3 4 5 6 7 4 chunks +6 lines, -4 lines 0 comments Download
M media/mp2t/mp2t_stream_parser_unittest.cc View 1 2 3 4 5 6 7 8 9 4 chunks +5 lines, -17 lines 0 comments Download
M media/mp3/mp3_stream_parser.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M media/mp3/mp3_stream_parser.cc View 1 2 3 4 5 6 7 8 9 3 chunks +2 lines, -2 lines 0 comments Download
M media/mp3/mp3_stream_parser_unittest.cc View 1 2 3 4 5 6 7 8 9 4 chunks +4 lines, -16 lines 0 comments Download
M media/mp4/mp4_stream_parser.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M media/mp4/mp4_stream_parser.cc View 1 2 3 4 5 6 7 3 chunks +2 lines, -2 lines 0 comments Download
M media/mp4/mp4_stream_parser_unittest.cc View 1 2 3 4 5 6 7 8 9 5 chunks +5 lines, -16 lines 0 comments Download
M media/webm/webm_cluster_parser.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +26 lines, -3 lines 0 comments Download
M media/webm/webm_cluster_parser_unittest.cc View 1 2 3 4 5 6 7 8 9 3 chunks +5 lines, -12 lines 0 comments Download
M media/webm/webm_stream_parser.h View 1 2 3 4 5 6 7 3 chunks +0 lines, -7 lines 0 comments Download
M media/webm/webm_stream_parser.cc View 1 2 3 4 5 6 7 8 9 8 chunks +6 lines, -37 lines 0 comments Download
M media/webm/webm_tracks_parser.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -8 lines 0 comments Download
M media/webm/webm_tracks_parser.cc View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -4 lines 0 comments Download
M media/webm/webm_tracks_parser_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 54 (0 generated)
Matthew Heaney (Chromium)
I just pushed up this CL for review. It adds support for inband text tracks ...
7 years, 3 months ago (2013-09-03 22:28:20 UTC) #1
fgalligan1
https://chromiumcodereview.appspot.com/23702007/diff/1/media/base/pipeline_unittest.cc File media/base/pipeline_unittest.cc (right): https://chromiumcodereview.appspot.com/23702007/diff/1/media/base/pipeline_unittest.cc#newcode466 media/base/pipeline_unittest.cc:466: TEST_F(PipelineTest, VideoTextStream) { Maybe add a Text only stream ...
7 years, 3 months ago (2013-09-04 22:23:09 UTC) #2
acolwell GONE FROM CHROMIUM
fyi: I'll try to get to reviewing this tomorrow. I've become a popular reviewer in ...
7 years, 3 months ago (2013-09-05 22:03:48 UTC) #3
acolwell GONE FROM CHROMIUM
Here is my initial round of comments. Some of them have cascading effects so I ...
7 years, 3 months ago (2013-09-12 00:15:14 UTC) #4
acolwell GONE FROM CHROMIUM
One other thing to consider is to create a new DemuxerTextStream interface instead of DemuxerStream ...
7 years, 3 months ago (2013-09-12 21:27:25 UTC) #5
Matthew Heaney (Chromium)
Incorporated a slew of Aaron's comments. I did leave a few questions behind to confirm ...
7 years, 3 months ago (2013-09-13 19:51:53 UTC) #6
acolwell GONE FROM CHROMIUM
Just answering questions. I'll hold of on further review until you have the DemuxerHost changes ...
7 years, 3 months ago (2013-09-13 20:57:30 UTC) #7
Matthew Heaney (Chromium)
I incorporated (most of) Aaron's suggestions. One issue that came up is that TextTrack manipulation ...
7 years, 3 months ago (2013-09-20 23:53:54 UTC) #8
acolwell GONE FROM CHROMIUM
I didn't do a full review since it appears that you just wanted answers about ...
7 years, 2 months ago (2013-09-25 23:23:09 UTC) #9
acolwell GONE FROM CHROMIUM
I didn't do a full review since it appears that you just wanted answers about ...
7 years, 2 months ago (2013-09-25 23:23:09 UTC) #10
acolwell GONE FROM CHROMIUM
I didn't do a full review since it appears that you just wanted answers about ...
7 years, 2 months ago (2013-09-25 23:23:09 UTC) #11
acolwell GONE FROM CHROMIUM
Accidentally sent too early. static void OnRemoveTrack(scoped_ptr<WebInbandTextTrackImpl> text_track) { if (text_track->client()) client_->removeTextTrack(text_track.get()); } TextTrackImpl::~TextTrackImpl() message_loop_proxy_->PostTask(FROM_HERE, ...
7 years, 2 months ago (2013-09-25 23:25:17 UTC) #12
Matthew Heaney (Chromium)
Incorporated Aaron's comments. In this patch, I moved the text track map from WebMediaPlayerImpl to ...
7 years, 2 months ago (2013-09-29 03:31:23 UTC) #13
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/23702007/diff/36001/content/renderer/media/texttrack_impl.cc File content/renderer/media/texttrack_impl.cc (right): https://codereview.chromium.org/23702007/diff/36001/content/renderer/media/texttrack_impl.cc#newcode39 content/renderer/media/texttrack_impl.cc:39: if (WebKit::WebInbandTextTrackClient* client = text_track_->client()) { I don't think ...
7 years, 2 months ago (2013-10-08 15:45:24 UTC) #14
Matthew Heaney (Chromium)
I incorporated Aaron's comments. This patch set includes the changes to the chunk demuxer. https://chromiumcodereview.appspot.com/23702007/diff/36001/content/renderer/media/texttrack_impl.cc ...
7 years, 2 months ago (2013-10-13 05:30:17 UTC) #15
acolwell GONE FROM CHROMIUM
Looking pretty good. https://chromiumcodereview.appspot.com/23702007/diff/49001/content/renderer/media/webmediaplayer_impl.cc File content/renderer/media/webmediaplayer_impl.cc (right): https://chromiumcodereview.appspot.com/23702007/diff/49001/content/renderer/media/webmediaplayer_impl.cc#newcode955 content/renderer/media/webmediaplayer_impl.cc:955: const webkind_t webkind = static_cast<webkind_t>(kind); nit: ...
7 years, 2 months ago (2013-10-14 20:42:23 UTC) #16
Matthew Heaney (Chromium)
I added a TextTrackConfig and added it add a parameter to the OnNewConfigs callback. The ...
7 years, 2 months ago (2013-10-17 05:46:43 UTC) #17
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/23702007/diff/61001/content/renderer/media/texttrack_impl.cc File content/renderer/media/texttrack_impl.cc (right): https://codereview.chromium.org/23702007/diff/61001/content/renderer/media/texttrack_impl.cc#newcode19 content/renderer/media/texttrack_impl.cc:19: WebInbandTextTrackImpl* text_track) nit: make scoped_ptr<WebInbandTextTrackImpl> https://codereview.chromium.org/23702007/diff/61001/content/renderer/media/texttrack_impl.cc#newcode31 content/renderer/media/texttrack_impl.cc:31: text_track_.release())); You ...
7 years, 2 months ago (2013-10-21 20:10:40 UTC) #18
Matthew Heaney (Chromium)
Incorporated Aaron's comments. Aaron answered a few questions that I had about changes to the ...
7 years, 2 months ago (2013-10-23 05:09:00 UTC) #19
acolwell GONE FROM CHROMIUM
Getting closer. I'm pretty happy with the way this is turning out. :) Aside from ...
7 years, 2 months ago (2013-10-24 18:57:51 UTC) #20
philipj_slow
Is the title of this review misleading, or does it really mean that text rendering ...
7 years, 2 months ago (2013-10-24 21:48:39 UTC) #21
acolwell GONE FROM CHROMIUM
On 2013/10/24 21:48:39, philipj wrote: > Is the title of this review misleading, or does ...
7 years, 2 months ago (2013-10-24 22:05:36 UTC) #22
acolwell GONE FROM CHROMIUM
On 2013/10/24 21:48:39, philipj wrote: > Is the title of this review misleading, or does ...
7 years, 2 months ago (2013-10-24 22:05:41 UTC) #23
Matthew Heaney (Chromium)
Incorporated Aaron's comments. I had an outstanding question about the implementation of the mock demuxer ...
7 years, 2 months ago (2013-10-25 03:05:37 UTC) #24
acolwell GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/23702007/diff/178001/media/filters/ffmpeg_demuxer_unittest.cc File media/filters/ffmpeg_demuxer_unittest.cc (right): https://chromiumcodereview.appspot.com/23702007/diff/178001/media/filters/ffmpeg_demuxer_unittest.cc#newcode307 media/filters/ffmpeg_demuxer_unittest.cc:307: TEST_F(FFmpegDemuxerTest, Initialize_MultitrackText) { On 2013/10/25 03:05:38, Matthew Heaney (Chromium) ...
7 years, 2 months ago (2013-10-25 03:56:19 UTC) #25
Matthew Heaney (Chromium)
On 2013/10/25 03:56:19, acolwell wrote: > https://chromiumcodereview.appspot.com/23702007/diff/178001/media/filters/ffmpeg_demuxer_unittest.cc > File media/filters/ffmpeg_demuxer_unittest.cc (right): > > https://chromiumcodereview.appspot.com/23702007/diff/178001/media/filters/ffmpeg_demuxer_unittest.cc#newcode307 > ...
7 years, 1 month ago (2013-10-27 01:43:02 UTC) #26
Matthew Heaney (Chromium)
I pushed up another patch set (#9), with a small change to the ffmpeg demuxer ...
7 years, 1 month ago (2013-10-27 01:43:59 UTC) #27
acolwell GONE FROM CHROMIUM
Just a few more minor nits. The main code looks good, but you need to ...
7 years, 1 month ago (2013-10-29 21:14:18 UTC) #28
Matthew Heaney (Chromium)
Incorporated most of Aaron's comments from most recent review. This patch set also contains a ...
7 years, 1 month ago (2013-11-05 04:52:39 UTC) #29
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/23702007/diff/848001/media/base/text_renderer.cc File media/base/text_renderer.cc (right): https://codereview.chromium.org/23702007/diff/848001/media/base/text_renderer.cc#newcode96 media/base/text_renderer.cc:96: state_ = kPaused; Why is this transition needed now? ...
7 years, 1 month ago (2013-11-10 19:48:07 UTC) #30
Matthew Heaney (Chromium)
Fixed text renderer unit test per Aaron's suggestions. This patch set includes changes to the ...
7 years, 1 month ago (2013-11-13 05:44:48 UTC) #31
philipj_slow
https://codereview.chromium.org/74623002/ suggests creating more work for this review.
7 years, 1 month ago (2013-11-16 15:55:46 UTC) #32
philipj_slow
So, I've been seeing the APIs for in-band tracks in Blink a bit lately, and ...
7 years, 1 month ago (2013-11-16 16:00:50 UTC) #33
Matthew Heaney (Chromium)
On 2013/11/16 16:00:50, philipj wrote: > So, I've been seeing the APIs for in-band tracks ...
7 years, 1 month ago (2013-11-16 23:55:23 UTC) #34
Matthew Heaney (Chromium)
On 2013/11/16 16:00:50, philipj wrote: > So, I've been seeing the APIs for in-band tracks ...
7 years, 1 month ago (2013-11-16 23:55:36 UTC) #35
acolwell GONE FROM CHROMIUM
lgtm % comments My assumption is that you file bugs for any other outstanding issues ...
7 years, 1 month ago (2013-11-20 01:15:22 UTC) #36
Matthew Heaney (Chromium)
Integrated Aaron's suggestions. https://codereview.chromium.org/23702007/diff/1318001/media/base/pipeline.cc File media/base/pipeline.cc (right): https://codereview.chromium.org/23702007/diff/1318001/media/base/pipeline.cc#newcode947 media/base/pipeline.cc:947: text_renderer_->AddTextStream(text_stream, config); On 2013/11/20 01:15:24, acolwell ...
7 years, 1 month ago (2013-11-20 19:23:15 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matthewjheaney@chromium.org/23702007/1458001
7 years, 1 month ago (2013-11-20 19:31:11 UTC) #38
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=190873
7 years, 1 month ago (2013-11-20 19:46:33 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matthewjheaney@chromium.org/23702007/1688001
7 years, 1 month ago (2013-11-20 21:10:36 UTC) #40
commit-bot: I haz the power
Retried try job too often on linux_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=156982
7 years, 1 month ago (2013-11-20 22:22:29 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matthewjheaney@chromium.org/23702007/1958001
7 years, 1 month ago (2013-11-20 22:25:26 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matthewjheaney@chromium.org/23702007/1958001
7 years, 1 month ago (2013-11-21 01:35:14 UTC) #43
commit-bot: I haz the power
Failed to trigger a try job on win_x64_rel HTTP Error 400: Bad Request
7 years, 1 month ago (2013-11-21 02:35:45 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matthewjheaney@chromium.org/23702007/2148001
7 years, 1 month ago (2013-11-21 02:38:28 UTC) #45
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/23702007/diff/2148001/content/renderer/media/android/media_source_delegate.cc File content/renderer/media/android/media_source_delegate.cc (right): https://codereview.chromium.org/23702007/diff/2148001/content/renderer/media/android/media_source_delegate.cc#newcode511 content/renderer/media/android/media_source_delegate.cc:511: // TODO(matthewjheaney): do something here Put NOTIMPLEMENTED(); here and ...
7 years, 1 month ago (2013-11-21 02:49:17 UTC) #46
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=94535
7 years, 1 month ago (2013-11-21 04:21:41 UTC) #47
Matthew Heaney (Chromium)
Added CR note. https://codereview.chromium.org/23702007/diff/2148001/content/renderer/media/android/media_source_delegate.cc File content/renderer/media/android/media_source_delegate.cc (right): https://codereview.chromium.org/23702007/diff/2148001/content/renderer/media/android/media_source_delegate.cc#newcode511 content/renderer/media/android/media_source_delegate.cc:511: // TODO(matthewjheaney): do something here On ...
7 years, 1 month ago (2013-11-21 19:23:32 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matthewjheaney@chromium.org/23702007/2388001
7 years, 1 month ago (2013-11-21 19:26:10 UTC) #49
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=94720
7 years, 1 month ago (2013-11-21 20:11:34 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matthewjheaney@chromium.org/23702007/1488003
7 years, 1 month ago (2013-11-21 20:18:58 UTC) #51
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=55911
7 years, 1 month ago (2013-11-21 22:08:32 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matthewjheaney@chromium.org/23702007/2088003
7 years, 1 month ago (2013-11-21 22:15:27 UTC) #53
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 01:19:37 UTC) #54
Message was sent while issue was closed.
Change committed as 236660

Powered by Google App Engine
This is Rietveld 408576698